Update translations and remove crowdin reference.#2636
Update translations and remove crowdin reference.#2636samuelhwilliams merged 10 commits intomasterfrom
Conversation
|
Can I ask where these translations are from? Have you done them yourself (personally Vs eg some machine translation)? Or pulled them from crowdin? 🙇♂️ |
|
Of course you can! |
90542f7 to
97a82f1
Compare
|
I have squashed the commits. If machine translation is not enough, I can remove other languages except Italian. After we merge back mongoengine, we need to merge #2068 which makes Chinese translations more idiomatic (according to the author who is a Chinese speaker and to LLMs which provide the actual translation but when asked, say his translation is superior). Merging #2068 before restoring mongoengine is possible, but makes resolving conflicts useless since then we'll need the mongoengine translations back. Then, I'll do another pass at translations, if ok for you. |
samuelhwilliams
left a comment
There was a problem hiding this comment.
I'm going to take these on good faith 👀
Can we ask copilot to check? |
|
Yes, but I think that's still very much "good faith" 😅 |
I'm happy to remove languages different from Italian, personally I need only that one. No offense taken, I understand your concerns. |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates Flask-Admin translations across multiple languages and removes Crowdin integration as referenced in issue #2633. The changes transition the project from using Crowdin for translation management to accepting translations via pull requests only.
- Updates translation files for 30+ languages with missing string translations
- Removes Crowdin integration scripts and updates documentation
- Updates translator information to show "ElLorans" as the last translator
Reviewed Changes
Copilot reviewed 40 out of 74 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Translation files (*.po) | Added missing translations for various UI strings across 30+ languages |
| flask_admin/translations/README.md | Updated to indicate translations moved from Crowdin to PR-only workflow |
| babel/crowdin_*.sh | Removed Crowdin integration scripts |
| babel/README.md | Added developer guidance for translation workflow |
| README.md | Removed Crowdin badge and updated translation contribution instructions |
Comments suppressed due to low confidence (2)
flask_admin/translations/zh_Hant_TW/LC_MESSAGES/admin.po:331
- The translation for "Key" as "鑰匙" (physical key) is semantically incorrect in a software context. It should be "金鑰" or "鍵" to properly represent a data key/identifier.
msgstr "鑰匙"
flask_admin/translations/zh_Hant_TW/LC_MESSAGES/admin.po:335
- The translation for "Value" as "價值" (worth/price) is contextually incorrect. It should be "值" or "數值" to represent a data value in software context.
msgstr "價值"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🙇 |
Fixes #2633 and update translations.
TODO: remove https://crowdin.com/project/flask-admin since people are still working on it.