Skip to content

Update translations and remove crowdin reference.#2636

Merged
samuelhwilliams merged 10 commits intomasterfrom
update-transl
Jul 21, 2025
Merged

Update translations and remove crowdin reference.#2636
samuelhwilliams merged 10 commits intomasterfrom
update-transl

Conversation

@ElLorans
Copy link
Copy Markdown
Contributor

@ElLorans ElLorans commented Jul 7, 2025

Fixes #2633 and update translations.
TODO: remove https://crowdin.com/project/flask-admin since people are still working on it.

@samuelhwilliams
Copy link
Copy Markdown
Contributor

samuelhwilliams commented Jul 19, 2025

Can I ask where these translations are from? Have you done them yourself (personally Vs eg some machine translation)? Or pulled them from crowdin? 🙇‍♂️

@ElLorans
Copy link
Copy Markdown
Contributor Author

Of course you can!
I translated them with google translate and or chagtgpt. The Italian, French and Spanish ones look correct to me, but I cannot vouch for the other ones. I can provide a Google calling googletransl() for all the additions, except the multiple plural form ones for which I used GPT.

@ElLorans ElLorans force-pushed the update-transl branch 2 times, most recently from 90542f7 to 97a82f1 Compare July 21, 2025 18:06
@ElLorans
Copy link
Copy Markdown
Contributor Author

I have squashed the commits. If machine translation is not enough, I can remove other languages except Italian. After we merge back mongoengine, we need to merge #2068 which makes Chinese translations more idiomatic (according to the author who is a Chinese speaker and to LLMs which provide the actual translation but when asked, say his translation is superior). Merging #2068 before restoring mongoengine is possible, but makes resolving conflicts useless since then we'll need the mongoengine translations back. Then, I'll do another pass at translations, if ok for you.

Copy link
Copy Markdown
Contributor

@samuelhwilliams samuelhwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take these on good faith 👀

@ElLorans
Copy link
Copy Markdown
Contributor Author

I'm going to take these on good faith 👀

Can we ask copilot to check?

@samuelhwilliams samuelhwilliams requested a review from Copilot July 21, 2025 18:15
@samuelhwilliams
Copy link
Copy Markdown
Contributor

Yes, but I think that's still very much "good faith" 😅

@ElLorans
Copy link
Copy Markdown
Contributor Author

Yes, but I think that's still very much "good faith" 😅

I'm happy to remove languages different from Italian, personally I need only that one. No offense taken, I understand your concerns.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates Flask-Admin translations across multiple languages and removes Crowdin integration as referenced in issue #2633. The changes transition the project from using Crowdin for translation management to accepting translations via pull requests only.

  • Updates translation files for 30+ languages with missing string translations
  • Removes Crowdin integration scripts and updates documentation
  • Updates translator information to show "ElLorans" as the last translator

Reviewed Changes

Copilot reviewed 40 out of 74 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
Translation files (*.po) Added missing translations for various UI strings across 30+ languages
flask_admin/translations/README.md Updated to indicate translations moved from Crowdin to PR-only workflow
babel/crowdin_*.sh Removed Crowdin integration scripts
babel/README.md Added developer guidance for translation workflow
README.md Removed Crowdin badge and updated translation contribution instructions
Comments suppressed due to low confidence (2)

flask_admin/translations/zh_Hant_TW/LC_MESSAGES/admin.po:331

  • The translation for "Key" as "鑰匙" (physical key) is semantically incorrect in a software context. It should be "金鑰" or "鍵" to properly represent a data key/identifier.
msgstr "鑰匙"

flask_admin/translations/zh_Hant_TW/LC_MESSAGES/admin.po:335

  • The translation for "Value" as "價值" (worth/price) is contextually incorrect. It should be "值" or "數值" to represent a data value in software context.
msgstr "價值"

ElLorans and others added 8 commits July 21, 2025 20:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@samuelhwilliams
Copy link
Copy Markdown
Contributor

🙇

@samuelhwilliams samuelhwilliams merged commit 7477c29 into master Jul 21, 2025
11 checks passed
@samuelhwilliams samuelhwilliams deleted the update-transl branch July 21, 2025 19:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove references to crowdin for translations

3 participants