Skip to content

Review, fix and make Spanish translations more natural#1152

Merged
jwag956 merged 4 commits intopallets-eco:mainfrom
arielvb:review-spanish-transaltions
Dec 6, 2025
Merged

Review, fix and make Spanish translations more natural#1152
jwag956 merged 4 commits intopallets-eco:mainfrom
arielvb:review-spanish-transaltions

Conversation

@arielvb
Copy link
Contributor

@arielvb arielvb commented Dec 3, 2025

Hi, Chris,

Thank you for merging the Catalan translations (#1151)!

I have reviewed the Spanish translations. Although they were already translated, some of them didn't sound natural and seemed to be heavily influenced by Google Translate.

I appreciate the work of the previous translator, Giorgio @gissimo , and believe he would agree with these changes to make the translations more natural and accurate.

Here are a few examples of the improvements made:

  • "Welcome %(email)s" was incorrectly translated as 'Bienvenido a' (Welcome to %(email)s). It has been corrected to 'Bienvenido'.
  • "Two-factor" was translated as 'dos factores' (two factors), but in Spain, we commonly use 'doble factor' (double factor).

Thank you for all your work on Flask-Security!

Best regards,

Ariel

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.52%. Comparing base (96859ee) to head (2bfedb0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1152   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          40       40           
  Lines        5008     5008           
=======================================
  Hits         4934     4934           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sr-verde
Copy link
Contributor

sr-verde commented Dec 3, 2025

You may want to add your name to the authors in the comments at the beginning of the file.

@arielvb
Copy link
Contributor Author

arielvb commented Dec 3, 2025

Hi, @sr-verde,

Thank you for your suggestion! I've just added a new commit to include me on both Catalan and Spanish catalogs.

Copy link
Contributor

@gissimo gissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ariel, thank for your contributions. No comments whatsoever on most of your changes, but one: whenever I've used "Bienvenido·a". It is a way to address to both female and male users. I believe it is important to keep it like this. Sounds good?

@gissimo
Copy link
Contributor

gissimo commented Dec 3, 2025

Btw - no machine translation here - all by hand, that's why some things I have overlooked.

@arielvb
Copy link
Contributor Author

arielvb commented Dec 3, 2025

@gissimo you did a great work! And you're right that my translations using "Bienvenido" aren't gender inclusive.

In Spain we use a / to include both genders, see page 5 of this document. Because you used a '·', I didn't recognize your intentions!

I'll add a new commit, modifying all "Bienvenido" with "Bienvenido/a".

@jwag956 jwag956 merged commit 35f883b into pallets-eco:main Dec 6, 2025
16 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants