Fix type-var for idx in Series.loc.__setitem__(...)#1670
Merged
cmp0xff merged 4 commits intopandas-dev:mainfrom Feb 12, 2026
Merged
Fix type-var for idx in Series.loc.__setitem__(...)#1670cmp0xff merged 4 commits intopandas-dev:mainfrom
idx in Series.loc.__setitem__(...)#1670cmp0xff merged 4 commits intopandas-dev:mainfrom
Conversation
cmp0xff
requested changes
Feb 10, 2026
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Could you add a test to verify your changes? Maybe in test_series_loc_setitem in test_indexing.py.
cmp0xff
requested changes
Feb 11, 2026
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
cmp0xff
approved these changes
Feb 12, 2026
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Looks good. Thank you @Azureblade3808 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1669 .
Series.loc.__setitem__#1669 (Replace xxxx with the Github issue number)assert_type()to assert the type of any return value)AGENTS.md.