Skip to content

Fix type-var for idx in Series.loc.__setitem__(...) #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmp0xff merged 4 commits into from
Feb 12, 2026
Merged

Fix type-var for idx in Series.loc.__setitem__(...) #1670

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c407b75
Fix type-var for `idx` in `Series.loc.__setitem__(...)`
Azureblade3808 Feb 10, 2026
3bf503d
TST: GH1669 Add testing to `Series.loc.__setitem__` when element type…
Azureblade3808 Feb 11, 2026
2ab984c
Fix newly added part in `test_series_loc_setitem` so that it could be…
Azureblade3808 Feb 11, 2026
11478ba
Change `IndexOpsMixin[Any]` to `IndexOpsMixin`
Azureblade3808 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ class _LocIndexerSeries(_LocIndexer, Generic[S1]):
@overload
def __setitem__(
self,
idx: IndexOpsMixin[S1] | MaskType | slice,
idx: IndexOpsMixin[Any] | MaskType | slice,
value: S1 | ArrayLike | IndexOpsMixin[S1] | None,
) -> None: ...
@overload
Expand Down
6 changes: 6 additions & 0 deletions tests/series/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ def test_series_loc_setitem() -> None:
v = s.loc[[0, 2, 4]].values
s.loc[[0, 2, 4]] = v

# GH 1669
s = pd.Series([1, 2, 3, 4, 5], index=["a", "b", "c", "d", "e"])
idx = pd.Index(["a", "c", "e"])
v = s.loc[idx].values
s.loc[idx] = v


def test_series_isin() -> None:
s = pd.Series([1, 2, 3, 4, 5])
Expand Down