BUG: Retain index when merging on an index #59646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an index argument that tells merging how to choose the output index. I moved the logic determining which index to use into _MergeOperation.__init__ while moving the logic for calculating the index to the end of the _get_join_info method. Note: I did not adjust the logic in the case when merging on both indexes (or an index and a multiindex). This commit also introduces a function merge_pick_index so that internal uses of merge can pick where they get the index from. Specifically, join uses merge under the hood, but wants the old merge index sources. Now, join specifies the index source so it wont be affected by changing merge's index behavior. This commit should not affect behavior.
This commit changes the index source to fix the bug. It also corrects many tests which tested for the old indexes.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Since
joinuses amergeinternally, changing the index returned bymergewould cause problems forjoin. To prevent this, I introduced a new argument that would control which index is returned by a merge operation. I also separated out the logic that determined what index to use from the code that created the indexers. Not sure this was the best way to fix this; apologies if I bit off more than I could chew.