Skip to content

BUG: fix #60128 BUG: Series.combine_first loss of precision #60166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BUG: fix #60128 BUG: Series.combine_first loss of precision #60166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8640,7 +8640,10 @@ def combine(
"""
other_idxlen = len(other.index) # save for compare

this, other = self.align(other)
fill_value_for_align = None
if all(self.dtypes.eq(np.int64)) and all(other.dtypes.eq(np.int64)):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a lot more robust, e.g. can't only be for int64.

fill_value_for_align = 0
this, other = self.align(other, fill_value=fill_value_for_align)
new_index = this.index

if other.empty and len(new_index) == len(self.index):
Expand Down