BUG: Assigning boolean series with boolean indexer #61743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/SpoopyPillow/pandas into bug_boolean_series_with_logical_indexer
…with_logical_indexer
yuanx749
changed the title
simonjayhawkins
added
Bug
Indexing
mroeschke
reviewed
Jun 30, 2025
mroeschke
reviewed
Jun 30, 2025
| @@ -1926,7 +1926,12 @@ def np_can_hold_element(dtype: np.dtype, element: Any) -> Any: | |||
| # i.e. there are pd.NA elements | |||
| raise LossySetitemError | |||
| return element | |||
| # GH 57338 check boolean array set as object type | |||
| if tipo.kind == "O" and isinstance(element, np.ndarray): | |||
There was a problem hiding this comment.
Could you add a test where element has a np.nan value too?
There was a problem hiding this comment.
I added in test_can_hold_element.py.
Co-authored-by: Matthew Roeschke <[email protected]>
yuanx749
force-pushed
the
bug_boolean_series_with_logical_indexer
branch
from
e8e097b to
c4f32d7
Compare
…with_logical_indexer
mroeschke
approved these changes
Jul 1, 2025
|
Thanks @yuanx749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #60127
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.