-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
BUG: Assigning boolean series with boolean indexer #61743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 19 commits into
pandas-dev:main
from
yuanx749:bug_boolean_series_with_logical_indexer
Jul 1, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5dba4cc
extra check when casting to boolean
SpoopyPillow f431efc
full check for casting to boolean
SpoopyPillow 50f9a20
specify bug
SpoopyPillow 8100987
Merge branch 'main' into bug_boolean_series_with_logical_indexer
SpoopyPillow 6366303
fixed comparison with 1 and 0
SpoopyPillow a4316e1
Merge branch 'bug_boolean_series_with_logical_indexer' of https://git…
SpoopyPillow 592fc5d
return casted as bool
SpoopyPillow 14daddf
using lib is_bool to check for bool
SpoopyPillow d1548b0
made element iterable
SpoopyPillow aee48c9
ravel instead of flatten
SpoopyPillow 079c403
more efficient check
SpoopyPillow e8c1025
added test case
SpoopyPillow 0232b8b
format
SpoopyPillow c3d6fc4
Merge remote-tracking branch 'upstream/main' into bug_boolean_series_…
yuanx749 380b410
Improve fix
yuanx749 fe37a44
Add test and note
yuanx749 a85e387
Update pandas/core/dtypes/cast.py
yuanx749 c4f32d7
Add test for np.nan
yuanx749 7dc3ac1
Merge remote-tracking branch 'upstream/main' into bug_boolean_series_…
yuanx749 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test where
element
has anp.nan
value too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added in
test_can_hold_element.py
.