ENH: read_csv dialect parameter can take a string (GH8703) #8718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrasibule
changed the title
There was a problem hiding this comment.
check if isinstance(dialect, compat.string_types)
There was a problem hiding this comment.
csv.list_dialects() is a list of strings so the test should be more stringent already. Will add it if you think it's necessary.
|
I closed this PR and opened a new one by mistake, sorry for the noise. The new PR #8719 should reflect the test changes. |
|
@thrasibule For the future, it is not needed to open a new PR. Just push the new commit to the same branch on your github fork, and the PR will be automatically updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8703