ENH: read_csv dialect parameter can take a string (GH8703) #8719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrasibule
force-pushed
the
fix-csv-dialect
branch
from
45ab13b to
c782978
Compare
|
Looks good. Pls add a release note in v0.15.1 bug fix section referencing the original issue. Ping when pushed and green |
|
@thrasibule pls add a release note |
thrasibule
force-pushed
the
fix-csv-dialect
branch
from
81aa41b to
3043d4a
Compare
|
thanks! this was gr8! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8703
I wasn't sure where to put the test, hopefully this is right.
Follow-up of #8718