Added number badge on top the tab icon to show the number of active conversations#421
Open
arjenrschat wants to merge 4 commits intopapercups-io:masterfrom
Open
Added number badge on top the tab icon to show the number of active conversations#421arjenrschat wants to merge 4 commits intopapercups-io:masterfrom
arjenrschat wants to merge 4 commits intopapercups-io:masterfrom
Conversation
- fixes to render correctly in firefox - correct size - the icon is aligned to a 2x2 grid to render crisp on retina - has update colours that work on light and dark mode Added: Show number of active conversations on top of the badge icon
reichert621
reviewed
Nov 30, 2020
Collaborator
reichert621
left a comment
There was a problem hiding this comment.
hey @arjenrschat! thanks for sharing this, we'll definitely play around with it and see if it looks good to merge :)
a couple things:
- was most of the code copy/pasted from somewhere? if so, can you share the link?
- how many numbers does this support? i.e. if there are 99 messages, will it show "99" in the icon badge?
- is there a way we can make the number fit in the red circle more nicely?
Author
Collaborator
|
got it! maybe we can start off simple with something like Slack, and just show a red dot when there are unread messages... I think that will look nicer for the time being |
Author
|
The number is removed from the badge |
Collaborator
|
thanks @arjenrschat -- can you share a screenshot of how the latest code looks in both light and dark mode? |
added 2 commits
December 2, 2020 09:42
Added data-react-helmet property to the link, this forces Helmet to override the existing icon Removed Canvas rendering Added logo with unread badge
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
Improved logo.svg
- fixes to render correctly in firefox
- correct size
- the icon is aligned to a 2x2 grid to render crisp on retina
- has update colours that work on light and dark mode
Added: Show number of active conversations on top of the badge icon
Screenshots