Skip to content

Added number badge on top the tab icon to show the number of active conversations #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arjenrschat wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added number badge on top the tab icon to show the number of active conversations #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
939da3c
Improved logo.svg
Nov 27, 2020
ee0f63c
Only show a red badge, without the number to indicate there are unrea…
Nov 30, 2020
710b096
Merge branch 'master' into dev-icon-badge
Dec 2, 2020
9f73c38
Fixed: Show unread icon in Chrome
Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/logo.svg" />
<link rel="mask-icon" href="%PUBLIC_URL%/logo.svg" color="#000000" />
<link rel="icon" href="%PUBLIC_URL%/logo.svg" data-react-helmet="true"/>
<link rel="mask-icon" href="%PUBLIC_URL%/logo.svg" color="#000000"/>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#000000" />
<!-- TODO: come up with better meta tags -->
Expand Down
18 changes: 18 additions & 0 deletions assets/public/logo-unread.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 11 additions & 14 deletions assets/public/logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 28 additions & 2 deletions assets/src/components/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useEffect, useState} from 'react';
import React, {useEffect, useRef, useState} from 'react';
import {
useLocation,
Switch,
Expand Down Expand Up @@ -67,6 +67,30 @@ const shouldDisplayChat = (pathname: string) => {
return true;
};

const ShortcutIcon = ({totalNumUnread}: {totalNumUnread: number}) => {

const iconLink = '/logo.svg'
const iconUnreadLink = '/logo-unread.svg'
const [data, setData] = useState(iconLink);

useEffect(() => {
if(totalNumUnread){
setData(iconUnreadLink)
} else{
setData(iconLink)
}
})

return (
<div className="" style={{position:'absolute', zIndex: 1, display: 'none'}}>
<Helmet defer={false}>
<link rel="icon" href={data}></link>
</Helmet>
</div>
)

}

// TODO: not sure if this is the best way to handle this, but the goal
// of this component is to flash the number of unread messages in the
// tab (i.e. HTML title) so users can see when new messages arrive
Expand Down Expand Up @@ -131,7 +155,9 @@ const Dashboard = (props: RouteComponentProps) => {

return (
<Layout>
<DashboardHtmlHead totalNumUnread={totalNumUnread} />
<ShortcutIcon totalNumUnread={totalNumUnread} />



<Sider
width={220}
Expand Down