api: Validate the profile type before ingestion#6061
Merged
Conversation
|
✅ Meticulous spotted 0 visual differences across 321 screens tested: view results. Meticulous evaluated ~5 hours of user flows against your PR. Expected differences? Click here. Last updated for commit ad225d8. This comment will update as new commits are pushed. |
brancz
reviewed
Nov 24, 2025
Member
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
I like the “parse don’t validate” approach!
| } | ||
|
|
||
| for rowIdx := 0; rowIdx < int(r.NumRows()); rowIdx++ { | ||
| profileType, err := getProfileTypeString(r, rowIdx) |
Member
There was a problem hiding this comment.
This function searches for the producer column on every iteration, let’s only find the column once and then on every iteration do this validation.
brancz
reviewed
Nov 24, 2025
|
|
||
| schema := r.Schema() | ||
|
|
||
| nameCol := r.Column(schema.FieldIndices(profile.ColumnName)[0]) |
Member
There was a problem hiding this comment.
This is user-supplied data, so we shouldn't panic if there is no field index
Contributor
Author
There was a problem hiding this comment.
Oh yeah makes sense. Fixing it.
brancz
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.