Skip to content

api: Validate the profile type before ingestion #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brancz merged 5 commits into from
Nov 24, 2025
Merged

api: Validate the profile type before ingestion #6061

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bc87e1
Validate the profile type before ingestion
manojVivek Nov 24, 2025
5faa912
Review comment addressed
manojVivek Nov 24, 2025
a129b35
Fix a linter complaint
manojVivek Nov 24, 2025
9e6afc1
Fixed the test file
manojVivek Nov 24, 2025
ad225d8
Proper error handling
manojVivek Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions pkg/profilestore/profilecolumnstore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,17 @@ func (s *ProfileColumnStore) writeSeries(ctx context.Context, req *profilestorep
return nil
}

schema := r.Schema()

nameCol := r.Column(schema.FieldIndices(profile.ColumnName)[0])
Copy link
Member

@brancz brancz Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is user-supplied data, so we shouldn't panic if there is no field index

Copy link
Contributor Author

@manojVivek manojVivek Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah makes sense. Fixing it.

sampleTypeCol := r.Column(schema.FieldIndices(profile.ColumnSampleType)[0])
sampleUnitCol := r.Column(schema.FieldIndices(profile.ColumnSampleUnit)[0])
periodTypeCol := r.Column(schema.FieldIndices(profile.ColumnPeriodType)[0])
periodUnitCol := r.Column(schema.FieldIndices(profile.ColumnPeriodUnit)[0])
durationCol := r.Column(schema.FieldIndices(profile.ColumnDuration)[0])

for rowIdx := 0; rowIdx < int(r.NumRows()); rowIdx++ {
profileType, err := getProfileTypeString(r, rowIdx)
profileType, err := getProfileTypeString(rowIdx, nameCol, sampleTypeCol, sampleUnitCol, periodTypeCol, periodUnitCol, durationCol)
if err != nil {
return fmt.Errorf("failed to get profile type at row %d: %v", rowIdx, err)
}
Expand All @@ -129,22 +138,13 @@ func (s *ProfileColumnStore) writeSeries(ctx context.Context, req *profilestorep
return s.ingester.Ingest(ctx, r)
}

func getProfileTypeString(r arrow.Record, rowIdx int) (string, error) {
schema := r.Schema()

nameIdx := schema.FieldIndices(profile.ColumnName)
sampleTypeIdx := schema.FieldIndices(profile.ColumnSampleType)
sampleUnitIdx := schema.FieldIndices(profile.ColumnSampleUnit)
periodTypeIdx := schema.FieldIndices(profile.ColumnPeriodType)
periodUnitIdx := schema.FieldIndices(profile.ColumnPeriodUnit)
durationIdx := schema.FieldIndices(profile.ColumnDuration)

nameEncoded := r.Column(nameIdx[0]).ValueStr(rowIdx)
sampleTypeEncoded := r.Column(sampleTypeIdx[0]).ValueStr(rowIdx)
sampleUnitEncoded := r.Column(sampleUnitIdx[0]).ValueStr(rowIdx)
periodTypeEncoded := r.Column(periodTypeIdx[0]).ValueStr(rowIdx)
periodUnitEncoded := r.Column(periodUnitIdx[0]).ValueStr(rowIdx)
duration := r.Column(durationIdx[0]).ValueStr(rowIdx)
func getProfileTypeString(rowIdx int, nameCol, sampleTypeCol, sampleUnitCol, periodTypeCol, periodUnitCol, durationCol arrow.Array) (string, error) {
nameEncoded := nameCol.ValueStr(rowIdx)
sampleTypeEncoded := sampleTypeCol.ValueStr(rowIdx)
sampleUnitEncoded := sampleUnitCol.ValueStr(rowIdx)
periodTypeEncoded := periodTypeCol.ValueStr(rowIdx)
periodUnitEncoded := periodUnitCol.ValueStr(rowIdx)
duration := durationCol.ValueStr(rowIdx)

nameBytes, err := base64.StdEncoding.DecodeString(nameEncoded)
if err != nil {
Expand Down
Loading