ui: Fix state sync between ProfileSelector & MatchersInput#6081
Merged
Conversation
The bug occurs because two separate instances of the useQueryState hook maintain independent local draft state: Fix here was to pass down the setDraftMatchers, commitDraft, and draftParsedQuery from the ProfileSelector down to the MatchersInput component.
|
✅ Meticulous spotted 0 visual differences across 318 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit b81bf56. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurs because two separate instances of the
useQueryStatehook will maintain independent local draft state which was the case here.We had one in the
ProfileSelector(where the search button actually triggers the query search) and another in theMatchersInput(where the "Enter" keyprees triggers the query search).Fix here was to pass down
setDraftMatchers,commitDraft, anddraftParsedQueryfrom theProfileSelectordown to theMatchersInputcomponent.