Skip to content

kvdb-rocksdb: Make snappy and jemalloc configurable features #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 5 commits into from
Nov 17, 2025
Merged

kvdb-rocksdb: Make snappy and jemalloc configurable features #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99959ae
support of `x-shadow` feature
xDimon Nov 5, 2025
919fec1
remove `x-shadow` feature
xDimon Nov 17, 2025
0780c17
bump version and update changelog
xDimon Nov 17, 2025
d0d4838
changelog fixup
xDimon Nov 17, 2025
e1d54c8
Apply suggestion from @bkchr
bkchr Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kvdb-rocksdb/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog].

## [Unreleased]

## [0.20.2] - 2025-11-17
- Make snappy and jemalloc configurable features [#950](https://github.com/paritytech/parity-common/pull/950)

## [0.20.1] - 2025-11-07
- Force compact the DB on startup and on heavy writes. [#949](https://github.com/paritytech/parity-common/pull/949)

Expand Down
15 changes: 6 additions & 9 deletions kvdb-rocksdb/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "kvdb-rocksdb"
version = "0.20.1"
version = "0.20.2"
description = "kvdb implementation backed by RocksDB"
rust-version = "1.71.1"
authors.workspace = true
Expand All @@ -18,14 +18,7 @@ kvdb = { workspace = true }
num_cpus = { workspace = true }
parking_lot = { workspace = true }
regex = { workspace = true }

# OpenBSD and MSVC are unteested and shouldn't enable jemalloc:
# https://github.com/tikv/jemallocator/blob/52de4257fab3e770f73d5174c12a095b49572fba/jemalloc-sys/build.rs#L26-L27
[target.'cfg(any(target_os = "openbsd", target_env = "msvc"))'.dependencies]
rocksdb = { workspace = true, features = ["snappy"] }

[target.'cfg(not(any(target_os = "openbsd", target_env = "msvc")))'.dependencies]
rocksdb = { workspace = true, features = ["snappy", "jemalloc"] }
rocksdb = { workspace = true, default-features = false, features = ["snappy"] }

[dev-dependencies]
alloc_counter = { workspace = true }
Expand All @@ -38,3 +31,7 @@ keccak-hash = { workspace = true }
sysinfo = { workspace = true }
ctrlc = { workspace = true }
chrono = { workspace = true }

[features]
default = []
jemalloc = ["rocksdb/jemalloc"]
Loading