kvdb-rocksdb: Make snappy and jemalloc configurable features
#950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
approved these changes
Nov 10, 2025
kamilsa
approved these changes
Nov 12, 2025
iceseer
approved these changes
Nov 12, 2025
bkchr
requested changes
Nov 12, 2025
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Please no.
What you want to do here is to make the jemalloc feature configurable. Aka you expose the feature from this crate and make it enabled by default. Basically what you already have done here. But, you don't introduce any kind of "x-shadow" feature, because that clearly doesn't belong here.
bkchr
reviewed
Nov 17, 2025
bkchr
changed the title
snappy and jemalloc configurable features
Member
|
@xDimon please update the Changelog file. |
xDimon
force-pushed
the
xDimon/shadow_simulation_support
branch
from
143437d to
919fec1
Compare
Contributor
Author
bkchr
approved these changes
Nov 17, 2025
kayabaNerve
added a commit
to serai-dex/serai
that referenced
this pull request
Dec 1, 2025
For hash-pinned dependencies, adds comments documenting the associated versions. Adds a pin to `slither-analyzer` which was prior missing. Updates to Monero 0.18.4.4. `mimalloc` now has the correct option set when building for `musl`. A C++ compiler is no longer required in its Docker image. The runtime's `Dockerfile` now symlinks a `libc.so` already present on the image instead of creating one itself. It also builds the runtime within the image to ensure it only happens once. The test to ensure the methodology is reproducible has been updated to not simply create containers from the image, yet rebuild the image entirely, accordingly. This also is more robust and arguably should have already been done. The pin to the exact hash of the `patch-polkadot-sdk` repo in every `Cargo.toml` has been removed. The lockfile already serves that role, simplifying updating in the future. The latest Rust nightly is adopted as well (superseding #697). The `librocksdb-sys` patch is replaced with a `kvdb-rocksdb` patch, removing a git dependency, thanks to paritytech/parity-common#950.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces an optional feature x-shadow that disables the use of jemalloc, as it leads to deadlocks when running under the Shadow network simulator.
Rationale:
In the Shadow simulation environment, the initialization of jemalloc becomes re-entrant due to Shadow’s interception of system calls. This reentrancy causes jemalloc to deadlock during startup. Disabling jemalloc under the x-shadow feature prevents these deadlocks and allows the simulation to run reliably, while keeping the allocator behavior unchanged for normal builds.