-
Notifications
You must be signed in to change notification settings - Fork 1k
Improve statement-store gossiping performance #9912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
f06dab8
Gossip only recent statements
AndreiEres eca57b4
Check if the store already has a statement before processing
AndreiEres 7b8aeb1
Reduce notification size if too large
AndreiEres 3e69999
Update metrics
AndreiEres 9a5decc
Update from github-actions[bot] running command 'prdoc --audience nod…
github-actions[bot] baeba9f
Update PRDOC
AndreiEres b0607bc
Update semver
AndreiEres 52fb0aa
Address review comments
AndreiEres f08c2a8
Fix types
AndreiEres 1e3e83b
Fix up
AndreiEres 8cdb31a
Fix up
AndreiEres a317299
Fix typo
AndreiEres 50ecef4
Remove unused var
AndreiEres 6b89e1c
Update validation queue size
AndreiEres a705c00
Add mocked handler for tests
AndreiEres 8703601
Add dirty test
AndreiEres 90c0799
Add more tests
AndreiEres bd3645e
Fix duplicate processing
AndreiEres 310e05b
Add more tests
AndreiEres ed55be3
Add metrics for ignored statements
AndreiEres 514ad77
Remove unused tokio
AndreiEres 0adf169
Fix tests
AndreiEres 6daaee0
Fix style
AndreiEres 0012b9e
Fix skipping very large statements
AndreiEres 6cf91c4
Update logging and metrics
AndreiEres 6891b17
Increase notification size
AndreiEres f52598f
Send async notifications
AndreiEres 5945066
Fix tests
AndreiEres b5b96eb
Add more logs
AndreiEres 971fe1e
Modify metrics setting
AndreiEres f47af22
Handle very slow or disconnected peers
AndreiEres dec3b53
Merge branch 'master' into AndreiEres/fix-statement-store-gossiping
AndreiEres 894d00e
Update substrate/client/network/statement/src/lib.rs
AndreiEres 10a1fff
Update
AndreiEres b8a1c2f
Merge branch 'master' into AndreiEres/fix-statement-store-gossiping
AndreiEres a3d15d2
Fix flaky test
AndreiEres 3e17ffb
Merge branch 'master' into AndreiEres/fix-statement-store-gossiping
AndreiEres File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
title: '[WIP] Fix statement-store gossiping' | ||
doc: | ||
- audience: Node Dev | ||
description: |- | ||
Fixes gossiping and scalability issues in the statement-store networking: | ||
reduces traffic by propagating only recent statements, skips duplicate processing, | ||
and splits large batches to stay under MAX_STATEMENT_NOTIFICATION_SIZE. | ||
crates: | ||
- name: sc-network-statement | ||
bump: minor | ||
- name: sc-statement-store | ||
bump: minor | ||
- name: sp-statement-store | ||
bump: minor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.