Open
Conversation
This reverts commit 3779923.
knk38
requested changes
Sep 26, 2021
Member
knk38
left a comment
knk38
left a comment
There was a problem hiding this comment.
Looks good, just a few doc stuff/ questions I had
| "http_port" : 8089, | ||
| "imei": "412222222", | ||
| "scrape_uplinks": false, | ||
| "enable_auto_dbtelem": false |
Member
There was a problem hiding this comment.
Not that this really matters, but this case works fine with telemetry on the hootl designated unit? I think I remember some issues with this
| # device.scrape_uplink() | ||
| if device.enable_auto_dbtelem: | ||
| device.dbtelem() | ||
| def rs(self, name, print=False): |
Member
There was a problem hiding this comment.
I think it would be good to note that we are designating follower to be the satellite that matters in this environment and the fact that we can only rs follower states
Collaborator
|
I think we can close this PR as we did complete this testing, but did not merge into final code base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prop HITL
Fixes #802
Summary of changes
HITL only works if adcs_box_controller.execute() is commented out of main control loop.