attempt reconnect by factoring out connect function #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before opening the PR, think:
If the answer to either of these questions is "no", refactor your code and open your PR when the answer to both questions is "yes".
PR Title
Fixes #. (Optional; sometimes PRs don't have an associated ticket)
Summary of changes
If it applies, take a chance to describe offshoot work or TODOs that are a part of your PR.
Testing
Describe your unit and functional testing. The testing should be at a level appropriate to demonstrate that your feature is sufficiently tested.
If you've got HITL or HOOTL run logs, the logs should go under the "Pull Request HITL Logs" folder on the OneDrive. Create a new subfolder with the # of this PR and put your items there. Note: the logs can be found after ptesting at
ptest/logs(pick the appropriately dated folder for the log containing a successful run.)The logs can be read via the ptest standalone plotter utility. See ptest/ for more details.
If your update does not require significant testing, argue why, or if you're deferring testing to another PR, create an issue ticket for the deferral and link it.
Constants
Describe any important diffs to the
constantsfile in the root level of the repository. Ensure that any constants you added to the code successfully made it into theconstantsfile. If not, wrap the missing constants withTRACKED_CONSTANTmacros and fixconstants_reporter.pyif necessary.Telemetry
Describe any important diffs to the
telemetryfile in the root level of the repository. Ensure that any telemetry you added to the code successfully made it into thetelemetryfile.Also, take the opportunity to add the telemetry into the appropriate flows in src/flow_data.csv.
Documentation Evidence
Post to ReadTheDocs, or