feat(ToolCall/DeepThinking/Tool Response): Add support for high contrast #728
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-728.surge.sh A11y report: https://chatbot-pr-chatbot-728-a11y.surge.sh |
lboehling
reviewed
Oct 31, 2025
| .pf-chatbot__tool-call { | ||
| --pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--control--read-only); | ||
| --pf-v6-c-card--BorderRadius: var(--pf-t--global--border--radius--small); | ||
| --pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--control--read-only); |
There was a problem hiding this comment.
i wonder if these should just use our border--color--default token instead of read-only? they would get the HC shade automatically if so.
@kaylachumley is there a reason why this is using the border--color--control--read-only token?
There was a problem hiding this comment.
I improperly applied the read only token here! lets use the default token lucia suggested
Member
Author
There was a problem hiding this comment.
Updated color! Was able to drop some styles.
thatblindgeye
approved these changes
Oct 31, 2025
rebeccaalpert
force-pushed
the
tool-calls-hcc
branch
from
b17c12d to
6ea6a9a
Compare
|
🎉 This PR is included in version 6.5.0-prerelease.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out a good way to do this without looking for the class on root since these have different border styles than our usual cards, and the token wasn't inheriting the HCC borders. Let me know if there is in fact a better way.
Affected demos: