Skip to content

feat(ToolCall/DeepThinking/Tool Response): Add support for high contrast #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccaalpert merged 2 commits into from
Nov 7, 2025
Merged

feat(ToolCall/DeepThinking/Tool Response): Add support for high contrast #728

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0938013
feat(ToolCall/DeepThinking/Tool Response): Add support for high contrast
rebeccaalpert Oct 21, 2025
6ea6a9a
Update color
rebeccaalpert Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/module/src/DeepThinking/DeepThinking.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@
.pf-chatbot__deep-thinking-body {
color: var(--pf-t--global--text--color--subtle);
}

:root:where(.pf-v6-theme-high-contrast) {
.pf-chatbot__deep-thinking {
--pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--high-contrast);
}
}
8 changes: 7 additions & 1 deletion packages/module/src/ToolCall/ToolCall.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.pf-chatbot__tool-call {
--pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--control--read-only);
--pf-v6-c-card--BorderRadius: var(--pf-t--global--border--radius--small);
--pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--control--read-only);
Copy link

@lboehling lboehling Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if these should just use our border--color--default token instead of read-only? they would get the HC shade automatically if so.

@kaylachumley is there a reason why this is using the border--color--control--read-only token?

Copy link

@kaylachumley kaylachumley Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improperly applied the read only token here! lets use the default token lucia suggested

Copy link
Member Author

@rebeccaalpert rebeccaalpert Nov 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated color! Was able to drop some styles.


overflow: unset;
row-gap: var(--pf-t--global--spacer--sm);
Expand Down Expand Up @@ -35,3 +35,9 @@
justify-content: flex-end;
}
}

:root:where(.pf-v6-theme-high-contrast) {
.pf-chatbot__tool-call {
--pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--high-contrast);
}
}
11 changes: 11 additions & 0 deletions packages/module/src/ToolResponse/ToolResponse.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,14 @@
--pf-v6-c-divider--Color: var(--pf-t--global--border--color--control--read-only);
}
}

:root:where(.pf-v6-theme-high-contrast) {
.pf-chatbot__tool-response,
.pf-chatbot__tool-response-card {
--pf-v6-c-card--BorderColor: var(--pf-t--global--border--color--high-contrast);

.pf-v6-c-divider {
--pf-v6-c-divider--Color: var(--pf-t--global--border--color--high-contrast);
}
}
}
Loading