Skip to content

Conversation

@rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Oct 28, 2025

Addition of high contrast styles created some weird borders - adjusting.

This technically works - I don't see a token I can plug into.

Demo: https://chatbot-pr-chatbot-741.surge.sh/patternfly-ai/chatbot/messages#custom-message-content (second one down - have to open expandable).

Before After
Screenshot 2025-10-29 at 8 48 30 AM Screenshot 2025-10-29 at 8 47 40 AM

This was originally based on a Mark Riggan design shopped around to senior management - we were asked to prove that it could be done with PatternFly, but we're inlining some things since he had a few weird styles.

Addition of high contrast styles created some weird borders - adjusting.
@rebeccaalpert rebeccaalpert linked an issue Oct 28, 2025 that may be closed by this pull request
@patternfly-build
Copy link

patternfly-build commented Oct 28, 2025

@rebeccaalpert rebeccaalpert marked this pull request as ready for review October 29, 2025 12:46
</Flex>
</AccordionToggle>
<AccordionContent id={stage.id.replace('-toggle', '')}>{renderCodeBlock(stage)}</AccordionContent>
<AccordionContent id={stage.id.replace('-toggle', '')} style={{ border: '0px' }}>
Copy link
Contributor

@thatblindgeye thatblindgeye Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works fine for this particular example, just thinking if we have to try dealing with a case where someone has this sort of implementation, but also have some content before/after the code block. @lboehling would this be the expected result for such a case, where only the codeblock has the HC border (vs PatternFly base has an HC border around the Accordion content itself)

We're also overiding the Accordion content background here I believe, though, so probably fine?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this works ^

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise LGTM, would still have the above question for design, but not really blocking here

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me too!

@rebeccaalpert rebeccaalpert merged commit b3a49bd into patternfly:main Oct 31, 2025
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.5.0-prerelease.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cluster installation demo high contrast

5 participants