-
Notifications
You must be signed in to change notification settings - Fork 34
chore(docs): Adjust live progress summary card demo #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Adjust live progress summary card demo #741
Conversation
Addition of high contrast styles created some weird borders - adjusting.
|
Preview: https://chatbot-pr-chatbot-741.surge.sh A11y report: https://chatbot-pr-chatbot-741-a11y.surge.sh |
| </Flex> | ||
| </AccordionToggle> | ||
| <AccordionContent id={stage.id.replace('-toggle', '')}>{renderCodeBlock(stage)}</AccordionContent> | ||
| <AccordionContent id={stage.id.replace('-toggle', '')} style={{ border: '0px' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works fine for this particular example, just thinking if we have to try dealing with a case where someone has this sort of implementation, but also have some content before/after the code block. @lboehling would this be the expected result for such a case, where only the codeblock has the HC border (vs PatternFly base has an HC border around the Accordion content itself)
We're also overiding the Accordion content background here I believe, though, so probably fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this works ^
thatblindgeye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise LGTM, would still have the above question for design, but not really blocking here
srambach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
lboehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me too!
|
🎉 This PR is included in version 6.5.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Addition of high contrast styles created some weird borders - adjusting.
This technically works - I don't see a token I can plug into.
Demo: https://chatbot-pr-chatbot-741.surge.sh/patternfly-ai/chatbot/messages#custom-message-content (second one down - have to open expandable).
This was originally based on a Mark Riggan design shopped around to senior management - we were asked to prove that it could be done with PatternFly, but we're inlining some things since he had a few weird styles.