Skip to content

chore(docs): Adjust live progress summary card demo #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebeccaalpert merged 1 commit into from
Oct 31, 2025
+3 −1
Merged

chore(docs): Adjust live progress summary card demo #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ternfly-docs/content/extensions/chatbot/examples/Messages/UserMessageWithExtraContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
if (isSimulationRunning && !userManuallyExpandedAccordion) {
setIsAccordionExpanded(getCurrentStage().id);
}
}, [progress, isSimulationRunning, userManuallyExpandedAccordion]);

Check warning on line 188 in packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessageWithExtraContent.tsx

View workflow job for this annotation

GitHub Actions / call-build-lint-test-workflow / lint 

React Hook useEffect has a missing dependency: 'getCurrentStage'. Either include it or remove the dependency array

const onExpandCard = (_event: React.MouseEvent) => {
setIsCardExpanded(!isCardExpanded);
Expand Down Expand Up @@ -366,7 +366,9 @@
<FlexItem>{stage.name}</FlexItem>
</Flex>
</AccordionToggle>
<AccordionContent id={stage.id.replace('-toggle', '')}>{renderCodeBlock(stage)}</AccordionContent>
<AccordionContent id={stage.id.replace('-toggle', '')} style={{ border: '0px' }}>
Copy link
Contributor

@thatblindgeye thatblindgeye Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works fine for this particular example, just thinking if we have to try dealing with a case where someone has this sort of implementation, but also have some content before/after the code block. @lboehling would this be the expected result for such a case, where only the codeblock has the HC border (vs PatternFly base has an HC border around the Accordion content itself)

We're also overiding the Accordion content background here I believe, though, so probably fine?

Copy link

@lboehling lboehling Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this works ^

{renderCodeBlock(stage)}
</AccordionContent>
</AccordionItem>
))}
</Accordion>
Expand Down Expand Up @@ -399,7 +401,7 @@
setIsExpanded(isExpanded);
};

const handleTabClick = (_event: any, tabIndex: string | number) => {

Check warning on line 404 in packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/UserMessageWithExtraContent.tsx

View workflow job for this annotation

GitHub Actions / call-build-lint-test-workflow / lint 

Unexpected any. Specify a different type
setActiveTabKey(tabIndex);
};

Expand Down
Loading