-
Notifications
You must be signed in to change notification settings - Fork 12
feat(high contrast): add border to some hover states #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The build for this is failing, and cursor says
and recommends adding before running |
thatblindgeye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to rebase after a PR for workflows was merged in. Just a note below.
packages/module/package.json
Outdated
| "@patternfly/react-core": "^6.4.0", | ||
| "@patternfly/react-styles": "^6.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicole had suggested I try keeping the patternfly versions in extensions as what they were, and just updating the docs framework version to the latest (6.28.9). We could try that here so that at least the docs build will allow showing the high contrast styles.
We would also probably want to add to the patternfly-docs.config.js file the following to get the switchers showing up and make it easier to test HC styles:
hasThemeSwitcher: true,
hasHighContrastSwitcher: true
|
|
||
| &:hover { | ||
| background-color: var(--pf-t--global--background--color--action--plain--hover); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lboehling @thatblindgeye I didn't add the hover background, just the outline. Git blame points to a change by @nicolethoen - anyone know why this was added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is this issue that might handle this: #88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like maybe it was applied to the filter side panel by accident and was only meant to be the vertical tabs?
#73 comments talk about a hover background on vertical tabs but it was also applied to the filter side panel, perhaps erroneously?

Fixes #87
Adds a high contrast border on a pseudoelement for filter side panel and vertical tabs when hovered.
Will need PatternFly 6.4 for the high contrast tokens.
Since there is no theme switcher, add
pf-v6-theme-high-contrastto the html tag to trigger high contrast mode.