Skip to content

feat(high contrast): add border to some hover states #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 8 commits into from
Dec 17, 2025
Merged

feat(high contrast): add border to some hover states #91

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69dbd1a
feat(high contrast): add border to some hover states
srambach Oct 23, 2025
a54b4a3
feat(high contrast): update PF version
srambach Oct 23, 2025
c196cd7
feat(high contrast): adjust versions used and enable switcher
srambach Oct 29, 2025
b705114
feat(high contrast): remove bg on filter, fix styles on props side panel
srambach Nov 19, 2025
9e794ed
feat(high contrast): use hc tokens
srambach Dec 4, 2025
5d3c295
feat(high contrast): fix indentation
srambach Dec 4, 2025
b1fdfc5
feat(high contrast): remove comments
srambach Dec 4, 2025
43eb2ba
feat(high contrast): fix horizontal scroll
srambach Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"patternfly"
],
"dependencies": {
"@patternfly/react-core": "^6.1.0",
"@patternfly/react-styles": "^6.1.0"
"@patternfly/react-core": "^6.4.0",
"@patternfly/react-styles": "^6.4.0"
Copy link
Contributor

@thatblindgeye thatblindgeye Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicole had suggested I try keeping the patternfly versions in extensions as what they were, and just updating the docs framework version to the latest (6.28.9). We could try that here so that at least the docs build will allow showing the high contrast styles.

We would also probably want to add to the patternfly-docs.config.js file the following to get the switchers showing up and make it easier to test HC styles:

  hasThemeSwitcher: true,
  hasHighContrastSwitcher: true

},
"peerDependencies": {
"react": "^17 || ^18 || ^19",
Expand All @@ -51,10 +51,10 @@
"devDependencies": {
"@octokit/rest": "^18.0.0",
"@patternfly/documentation-framework": "6.8.2",
"@patternfly/patternfly": "^6.1.0",
"@patternfly/patternfly": "^6.4.0",
"@patternfly/patternfly-a11y": "^4.3.1",
"@patternfly/react-code-editor": "^6.1.0",
"@patternfly/react-table": "^6.1.0",
"@patternfly/react-code-editor": "^6.4.0",
"@patternfly/react-table": "^6.4.0",
"monaco-editor": "0.34.1",
"react-monaco-editor": "0.51.0",
"rimraf": "^2.6.2",
Expand Down
21 changes: 20 additions & 1 deletion packages/module/sass/react-catalog-view-extension/_filter-side-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,26 @@

&:hover {
background-color: var(--pf-t--global--background--color--action--plain--hover);
}
Copy link
Member Author

@srambach srambach Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lboehling @thatblindgeye I didn't add the hover background, just the outline. Git blame points to a change by @nicolethoen - anyone know why this was added?

Copy link
Contributor

@thatblindgeye thatblindgeye Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this issue that might handle this: #88

Copy link
Member Author

@srambach srambach Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like maybe it was applied to the filter side panel by accident and was only meant to be the vertical tabs?
#73 comments talk about a hover background on vertical tabs but it was also applied to the filter side panel, perhaps erroneously?

position: relative;

&::after {
content: '';
position: absolute;
left: 0;
right: 0;
top: 0;
bottom: 0;
border-width: var(--pf-t--global--border--width--high-contrast--regular);
border-style: solid;
border-color: transparent;
border-radius: inherit;
pointer-events: none;
}

&::after {
border-color: var(--pf-t--global--border--color--high-contrast);
}
}

.pf-v6-c-check__label {
min-height: var(--pf-t--global--spacer--md);
Expand Down
19 changes: 19 additions & 0 deletions packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,30 @@
width: 100%;
word-break: break-word;
border-radius: var(--pf-t--global--border--radius--small);
position: relative;

&::after {
content: '';
position: absolute;
left: 0;
right: 0;
top: 0;
bottom: 0;
border-width: var(--pf-t--global--border--width--high-contrast--regular);
border-style: solid;
border-color: transparent;
Copy link
Contributor

@mcoker mcoker Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, we can use the action-plain border width token and change it for :hover below

Suggested change
border-color: transparent;
inset: 0;
border: var(--pf-t--global--border--width--action--plain--default) solid var(--pf-t--global--border--color--high-contrast);

border-radius: inherit;
pointer-events: none;
}

&:hover,
&:focus {
background-color: var(--pf-t--global--background--color--action--plain--hover);
text-decoration: none;

&::after {
border-color: var(--pf-t--global--border--color--high-contrast);
Copy link
Contributor

@mcoker mcoker Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-color: var(--pf-t--global--border--color--high-contrast);
border-width: var(--pf-t--global--border--width--action--plain--hover);

}
}

&.no-wrap {
Expand Down
2 changes: 1 addition & 1 deletion packages/module/src/components/react-catalog-view-extension.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading