fix(PageHeader): updated type to ReactNode #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
reviewed
Jul 3, 2025
Collaborator
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Looks like there's a linting issue.
dlabaj
approved these changes
Jul 7, 2025
|
🎉 This PR is included in version 6.3.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates here should allow ReactNode being passed to linkProps.label since that's only being passed as a child to the PF Button component (which accepts ReactNode).
Calling
Stringon the linkProps label and passing that to thelabelprop on Button is mainly a means to not break anything. The current codebase should render in the DOM alabelattribute with whatever is passed to linkProps.label, and all I'm doing is stringifying that in the case where a consumer is passing anything other than a string.With these fixes passing a ReactNode:
With these fixes passing a string:
Existing logic passing a ReactNode:
Existing logic passing a string: