Skip to content

fix(PageHeader): updated type to ReactNode #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

fix(PageHeader): updated type to ReactNode #759

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ac5fb
fix(PageHeader): updated type to ReactNode
thatblindgeye Jul 3, 2025
629ac48
Updated to fix lint failures
thatblindgeye Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/module/src/ContentHeader/ContentHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { PropsWithChildren, FunctionComponent } from 'react';
import type { PropsWithChildren, FunctionComponent, ReactNode } from 'react';
import {
Flex,
FlexItem,
Expand All @@ -17,7 +17,7 @@ import { createUseStyles } from 'react-jss';
/** extends ButtonProps */
export interface PageHeaderLinkProps extends ButtonProps {
/** Title for the link */
label: string;
label: ReactNode;
/** Indicates if the link points to an external page */
isExternal?: boolean;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/module/src/PageHeader/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { FunctionComponent } from 'react';
import type { FunctionComponent, ReactNode } from 'react';
import {
Button,
ButtonProps,
Expand All @@ -18,7 +18,7 @@ import { createUseStyles } from 'react-jss';
/** extends ButtonProps */
export interface PageHeaderLinkProps extends ButtonProps {
/** Title for the link */
label: string;
label: ReactNode;
/** Indicates if the link points to an external page */
isExternal?: boolean;
}
Expand Down
Loading