feat: Replace element save buttons with SaveButton and enforce permissions#470
Merged
paulgessinger merged 1 commit intomainfrom Feb 16, 2026
Merged
feat: Replace element save buttons with SaveButton and enforce permissions#470paulgessinger merged 1 commit intomainfrom
paulgessinger merged 1 commit intomainfrom
Conversation
paulgessinger
changed the title
…ions Replace explicit `Button` calls with the reusable `SaveButton` component in `StoragePathEditView` and `DocumentTypeEditView`. This centralizes the save logic, improves consistency, and reduces duplication. Add `.disabled(!model.permissions.test(.change))` to the manager edit view to prevent UI interaction when the user lacks change permissions. Include a preview wrapper that uses `NavigationStack` and sets `navigationTitle`, improving preview ergonomics. Log an informational message when a disabled edit action is attempted, helping developers identify unintended UI states.
paulgessinger
force-pushed
the
fix/element-edit-perms
branch
from
b6711ed to
c2b7a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace explicit
Buttoncalls with the reusableSaveButtoncomponent inStoragePathEditViewandDocumentTypeEditView. This centralizes the savelogic, improves consistency, and reduces duplication.
Add
.disabled(!model.permissions.test(.change))to the manager edit viewto prevent UI interaction when the user lacks change permissions.
Include a preview wrapper that uses
NavigationStackand setsnavigationTitle, improving preview ergonomics.Log an informational message when a disabled edit action is attempted,
helping developers identify unintended UI states.
Fixes #466