fix: ensure fields are marked optional when draft: true is set for find queries
#14388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-coldwell
changed the title
draft: true is set for find queriesdraft: true is set for find queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures the correct types are returned when using the Local API queries with
draft: truepassed as an option.Why?
Support for correct types when creating a draft document was setup in #14271 ,however, the types returned when querying a document (e.g. via Local API
find) withdraft: truestill returns incorrect types many fields marked required are possibly null but the types are non-null.How?
This was achieved by checking for the draft option in the generics which then eventually returns the same
DraftDataFromCollectiontype as introduced in #14271