fix: corrects page type tracking value cache poisoning#1171
Merged
danzhaaspaypal merged 2 commits intodevelopfrom Feb 4, 2025
Merged
fix: corrects page type tracking value cache poisoning#1171danzhaaspaypal merged 2 commits intodevelopfrom
danzhaaspaypal merged 2 commits intodevelopfrom
Conversation
Seavenly
approved these changes
Feb 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
## [1.66.0](v1.65.4...v1.66.0) (2025-02-04) ### Features * deprecate legacy messages and modals ([#1153](#1153)) ([267a3f9](267a3f9)) ### Bug Fixes * corrects page type tracking value cache poisoning ([#1171](#1171)) ([e6c5ad0](e6c5ad0)) * modal reopening animation ([#1167](#1167)) ([8c0ac5c](8c0ac5c)) ### Code Refactoring * fix de lt calculator spacing ([#1168](#1168)) ([7d87001](7d87001))
|
🎉 This PR is included in version 1.66.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Message page type tracking values have been frequently misreported due to CDN-cached and thus potentially poisoned tracking values being tracked instead of the value a merchant specifies. This bug fix provides the merchant-provided page type value for tracking.
It also passes the page type in the message req query params on message re-render.
Screenshots
Testing instructions
Request a paypal message with a specified page type. Use a tool like Proxyman to intercept the response and replace the PAGE_TYPE value from the meta tracking keys. Validate that the original, not the intercepted and replaced, tracking key value was logged in the glog req payload.