Skip to content

fix: corrects page type tracking value cache poisoning #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danzhaaspaypal merged 2 commits into from
Feb 4, 2025
Merged

fix: corrects page type tracking value cache poisoning #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35f151e
fixes page type tracking cache poisoning
danzhaaspaypal Jan 31, 2025
29bf865
more thorough fix
danzhaaspaypal Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/message/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ const Message = function ({ markup, meta, parentStyles, warnings }) {
merchantConfigHash: window.xprops.merchantConfigHash ?? null,
disableSetCookie: window.xprops.disableSetCookie ?? null,
features: window.xprops.features ?? null,
contextualComponents: window.xprops.contextualComponents ?? null
contextualComponents: window.xprops.contextualComponents ?? null,
pageType: window.xprops.pageType ?? null
});

const [serverData, setServerData] = createState({
Expand Down Expand Up @@ -129,7 +130,8 @@ const Message = function ({ markup, meta, parentStyles, warnings }) {
contextualComponents,
treatmentsHash,
disableSetCookie,
features
features,
pageType
} = xprops;

setProps({
Expand All @@ -146,7 +148,8 @@ const Message = function ({ markup, meta, parentStyles, warnings }) {
channel,
contextualComponents,
disableSetCookie,
features
features,
pageType
});

// Generate new MRID on message update.
Expand All @@ -172,7 +175,8 @@ const Message = function ({ markup, meta, parentStyles, warnings }) {
deviceID: getOrCreateDeviceID(),
treatments: treatmentsHash,
disableSetCookie,
features
features,
pageType
})
.filter(([, val]) => Boolean(val))
.reduce(
Expand Down
5 changes: 4 additions & 1 deletion src/library/zoid/message/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,13 @@ export default createGlobalVariableGetter('__paypal_credit_message__', () =>
value: ({ props }) => {
const { onReady } = props;
return ({ meta, activeTags, ts, requestDuration, messageRequestId }) => {
const { account, merchantId, index, modal, getContainer } = props;
const { account, merchantId, index, modal, getContainer, pageType } = props;
const { trackingDetails, offerType, ppDebugId } = meta;
const partnerClientId = merchantId && account.slice(10); // slice is to remove the characters 'client-id:' from account name

// overwrites potentially poisoned PAGE_TYPE value from cached trackingDetails
trackingDetails.PAGE_TYPE = pageType;

ppDebug(`Message Correlation ID: ${ppDebugId}`);

// Write deviceID and ts cookie from iframe localStorage to merchant domain localStorage
Expand Down
Loading