ISSUE-139957: fixing Achmea issues#105
Conversation
marekpelc-pega
commented
Feb 18, 2026
marekpelc-pega
commented
- fixing cursor position in input
- fixing exception when no columns provided to EditableTable
- fixing infinite loop caused by initing component to early
- fixing when rules in views inside embedded data
|
@marekpelc-pega Please take a look at failing build: 
|
marekpelc-pega
force-pushed
the
bugfix/pelcm/ISSUE-139957-Achmea-issues
branch
from
47e522d to
062b4ba
Compare
| const newComponent = this.componentsManager.upsert(oldComponent, newPConn.meta.type, [newPConn]); | ||
| let newComponent; | ||
| if (oldComponent) { | ||
| oldComponent.update(newPConn) |
There was a problem hiding this comment.
Missing semicolon in all places where upsert has been inlined.
|
|
||
| #evaluateWhenVisibility(contextName, visibilityExpression) { | ||
| let bVisibility = true; | ||
| // e.g. "@E .EmbeddedData_SelectedTestName == 'Readonly' && .EmbeddedData_SelectedSubCategory == 'Mode'" |
There was a problem hiding this comment.
You're evaluating @W here, not @E.
There was a problem hiding this comment.
implementation was changes so that in case od @W configProps.visibility is used
| #evaluateWhenVisibility(contextName, visibilityExpression) { | ||
| let bVisibility = true; | ||
| // e.g. "@E .EmbeddedData_SelectedTestName == 'Readonly' && .EmbeddedData_SelectedSubCategory == 'Mode'" | ||
| const aVisibility = visibilityExpression.split('&&'); |
There was a problem hiding this comment.
Are we supporting && only? What about other operators?
There was a problem hiding this comment.
code removed
| const valueEndIndex = property.lastIndexOf("'") - 1; | ||
| return { | ||
| ...properties, | ||
| [property.substr(keyStartIndex + 1, keyEndIndex - keyStartIndex - 1)]: property.substr(valueStartIndex + 1, valueEndIndex - valueStartIndex) |
There was a problem hiding this comment.
Looks like a piece of custom code for expression evaluation. Can't you use pcore/pconnect APIs here?
There was a problem hiding this comment.
code removed
| * | ||
| * @param type - type of component to create | ||
| * @param args - arguments to pass to the component's constructor | ||
| * @param init - if true, calls the component's init() method after creation |
There was a problem hiding this comment.
no longer valid
| /** | ||
| * Creates a component. | ||
| * | ||
| * Warning: We cannot init() component here because it may cause infinite loop. |
There was a problem hiding this comment.
Btw, you should be able to create & init components in all places where you are operating on local variables.
2 participants
