TASK-1828883: adding support for SimpleTableManual #94

marekpelc-pega · 2025-11-28T10:17:34Z

adding js component
adding native component
adding 'alive' flag to block updates from dead components
show display value for dropdown in readonly mode
few fixes in simple table
change requestBody to requestBodyQueue to support POST/PATCH requests one after another
fixing updateOptions in dropdown
adding Modal View Container component to support editing SimpleTableManual in popup

kaidotarma · 2025-12-10T08:14:02Z

@marekpelc-pega please keep this branch up to date with master.
Then we can test this branch while the fixes in master branch are also available. ;)

tomaszmlocek-pega · 2025-12-10T21:06:35Z

...nMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/ModalViewContainer.kt

+import com.pega.constellation.sdk.kmp.core.internal.ComponentManagerImpl.Companion.getComponentTyped
+import kotlinx.serialization.json.JsonObject
+
+class ModalViewContainerComponent(context: ComponentContext) : ContainerComponent(context) {


It should be marked with HideableComponent interface.

tomaszmlocek-pega · 2025-12-10T21:15:56Z

...onMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/SimpleTableManual.kt

+import kotlinx.serialization.json.JsonObject
+import kotlinx.serialization.json.jsonObject
+
+class SimpleTableManualComponent(context: ComponentContext) : BaseComponent(context) {


HideableComponent

tomaszmlocek-pega · 2025-12-10T21:47:04Z

ui-renderer-cmp/build.gradle.kts

                implementation(libs.kotlinx.datetime)
                implementation(libs.ksoup.http.parser)
+                implementation(libs.table.m3)
+                implementation("com.mohamedrejeb.dnd:compose-dnd:0.3.0")


why hardcoded package name?

tomaszmlocek-pega · 2025-12-11T09:43:02Z

...onMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/SimpleTableManual.kt

+        val columnsJsonArray = props.getJSONArray("columnLabels")
+        return columnsJsonArray.mapWithIndex { getString(it) }
+    }
+


extra new line

tomaszmlocek-pega · 2025-12-11T09:50:03Z

...ntedTest/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/GroupTest.kt

        waitForNode("Lists group heading", substring = true)
        waitForNode("List group instructions", substring = true)
        waitForNode("cars")
-        waitForNode("Encryption keys")


Why this change?

I've fixed that. It was passing earlier because the table was not actually loaded and we had only 1 label of the view.
Once the table gets loaded we get label twice and that caused this assert to fail (because waitForNode checks for exactly 1 element)
Repeating label is also an issue raised as ISSUE-138617

tomaszmlocek-pega · 2025-12-11T09:54:44Z

scripts/dxcomponents/components/containers/root-container.component.js

-import { Utils } from "../../helpers/utils.js";
-import { BaseComponent } from "../base.component.js";
+import {Utils} from "../../helpers/utils.js";
+import {BaseComponent} from "../base.component.js";


code formatting issue - here and in many other places in JS files

tomaszmlocek-pega · 2025-12-11T10:38:57Z

scripts/dxcomponents/components/containers/templates/template-utils.js

+    };
+}
+
+function updateFieldLabels (fields, configFields, primaryFieldsViewIndex, pConnect, options) {


code formatting - extra space

tomaszmlocek-pega · 2025-12-11T10:41:43Z

scripts/dxcomponents/components/widgets/action-buttons.component.js

    compId;
    type;
    props;
+    alive = false;


We should think about making all the components to inherit from BaseComponent at some point.

BaseComponent has pConn and action buttons and alert banner does not...
but we may think about some refactorings in the future

tomaszmlocek-pega · 2025-12-11T10:48:48Z

scripts/dxcomponents/components/containers/modal-view-container.component.js

+                ]
+                : [];
+
+        this.alertBannerComponents = banners.map((b) =>


In case there are some previous banners - should not we destroy them first?

we do that in line 247

tomaszmlocek-pega · 2025-12-11T10:54:23Z

scripts/dxcomponents/components/containers/templates/simple-table-manual.component.js

+    constructor(componentsManager, pConn) {
+        super(componentsManager, pConn);
+        this.type = "SimpleTableManual";
+        this.utils = new Utils();


utils is already initialized in the super class (BaseComponent).

tomaszmlocek-pega

I have put some minor comments but generally changes look fine.

such update happens in dropdown component when it is created and quickly destroyed. It happens because it is loading DP from server and once its loaded props are updated on dead component - assignment component - sending empty children prop once assignmentCardComponent is null

- adding ModalViewContainerComponent

…PATCH requests one after another. Sometimes 2 POST/PATCH requests are executed one after another so quickly that setting body occures twice before the calls are executed and 2nd request has 'null' body

…for props update

marekpelc-pega requested a review from a team as a code owner November 28, 2025 10:17

marekpelc-pega changed the title ~~TASK-1828883: adding support for SimpleTableManual~~ TASK-1828883: [WIP] adding support for SimpleTableManual Nov 28, 2025

marekpelc-pega force-pushed the feature/pelcm/ISSUE-137900-ed-table branch from 6ca1a36 to 53ab06e Compare December 2, 2025 15:36

marekpelc-pega changed the title ~~TASK-1828883: [WIP] adding support for SimpleTableManual~~ TASK-1828883: adding support for SimpleTableManual Dec 4, 2025

marekpelc-pega requested review from lukaszgajewski-pega, lukjj-public-pega and tomaszmlocek-pega December 9, 2025 07:54

marekpelc-pega force-pushed the feature/pelcm/ISSUE-137900-ed-table branch from 3e522b7 to f943ba6 Compare December 10, 2025 13:33

tomaszmlocek-pega reviewed Dec 10, 2025

View reviewed changes

tomaszmlocek-pega reviewed Dec 11, 2025

View reviewed changes

tomaszmlocek-pega approved these changes Dec 11, 2025

View reviewed changes

marekpelc-pega added 10 commits December 12, 2025 09:14

ISSUE-137900: SimpleTableSelect WIP POC

dd85cb9

TASK-1786159: show display value for dropdown in readonly mode

9d977f5

TASK-1786159: few fixes in simple table

7f44f1d

TASK-1828883: adding native component

b1a822d

TASK-1786159: add support for add/remove/reorder rows

1f44244

TASK-1786159: add support for add/edit row in popup

ff9b40e

- adding ModalViewContainerComponent

TASK-1786159: change requestBody to requestBodyQueue to support POST/…

0a8a6c2

…PATCH requests one after another. Sometimes 2 POST/PATCH requests are executed one after another so quickly that setting body occures twice before the calls are executed and 2nd request has 'null' body

TASK-1828883: fixing updateOptions in dropdown

0dcce27

TASK-1828883: simple table manual clean-up

ced4e50

marekpelc-pega and others added 11 commits December 12, 2025 09:14

TASK-1828883: fix banner component, making 'alive' property optional …

186af9a

…for props update

TASK-1828883: fixing ConstellationSdkBaseTest.kt

c7b88c5

TASK-1828883: change compose-hot-reload version to 1.0.0

de5d6e3

TASK-1832909: Editable table is now extracted as ui-component. (#95)

8ec85bf

TASK-1828883: fix duplicated labels in view and its template

231042f

TASK-1828883: minor refactoring in simple-table-manual.component.js

d80fec4

TASK-1828883: fixing group test

bc36f2c

TASK-1828883: adding banners for modal in SimpleTableManual

55b18fb

TASK-1828883: cleaning simple-table.component.js

bf2b646

TASK-1828883: cleaning template-utils.js

18d26c1

TASK-1828883: few minor review fixes

1fb80a9

marekpelc-pega force-pushed the feature/pelcm/ISSUE-137900-ed-table branch from f943ba6 to 1fb80a9 Compare December 12, 2025 09:08

TASK-1828883: fixing GroupTest

cc74416

marekpelc-pega merged commit 5b53664 into master Dec 12, 2025
3 checks passed

marekpelc-pega mentioned this pull request Dec 12, 2025

SimpleTable component only supports fieldGroup? #75

Closed

tomaszmlocek-pega linked an issue Dec 17, 2025 that may be closed by this pull request

SimpleTable component only supports fieldGroup? #75

Closed

TASK-1828883: adding support for SimpleTableManual #94

TASK-1828883: adding support for SimpleTableManual #94

Uh oh!

Conversation

marekpelc-pega commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaidotarma commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomaszmlocek-pega left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marekpelc-pega commented Nov 28, 2025 •

edited

Loading