ISSUE-138440: changes to enable calling ActionButtons event from ListViewComponent #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine.kt on main thread using activity lifecycleScope
marekpelc-pega
changed the title
Contributor
Author
|
attaching diff of changed ListViewComponent and ListViewRenderer so that autosubmit is performed after choosing option |
marekpelc-pega
changed the title
marekpelc-pega
force-pushed
the
feature/pelcm/ISSUE-138440
branch
from
f9d3098 to
c8c0a46
Compare
marekpelc-pega
force-pushed
the
feature/pelcm/ISSUE-138440
branch
from
c8c0a46 to
3b1940a
Compare
|
|
||
| class AndroidWebViewEngine( | ||
| private val context: Context, | ||
| private val lifecycleScope: CoroutineScope, |
Contributor
There was a problem hiding this comment.
I think that this not necessarily must be lifecycleScope. Pega form can be shown anywhere, even in a very small piece of the native client app and it should be tied with that. I would rather rename it to be more generic: scope: CoroutineScope
| val script = "window.sendEventToComponent('${id.id}', '$eventJson')" | ||
| webView.evaluateJavascript(script, null) | ||
| this.lifecycleScope.launch { | ||
| webView.evaluateJavascript(script, null) |
Contributor
There was a problem hiding this comment.
If evaluateJavascript must be called on Main thread, then switch contexts here. You can even use Main.immediate dispatcher
lukaszgajewski-pega
requested changes
Dec 11, 2025
Contributor
lukaszgajewski-pega
left a comment
lukaszgajewski-pega
left a comment
There was a problem hiding this comment.
Take a look at above comments:
- change prop name
- switch context to Main.immediate, do not depend on the scope injected
…constructor launch evaluateJavascript with Dispatchers.Main.immediate
marekpelc-pega
force-pushed
the
feature/pelcm/ISSUE-138440
branch
from
2dbbc23 to
0034d6b
Compare
lukaszgajewski-pega
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution does not add automatic submit feature for ListViewComponent but enables to do it with custom code in ListViewComponent and ListViewComponentRenderer
Attaching diff of changed ListViewComponent and ListViewRenderer so that autosubmit is performed after choosing option
listviewAutosubmit.txt