TASK-1828886-3: EmbeddedData tables tests by marekpelc-pega · Pull Request #99 · pegasystems/constellation-mobile-sdk

marekpelc-pega · 2026-01-13T11:11:58Z

No description provided.

…rrect)

… in text area

…eadings

lukaszgajewski-pega · 2026-01-15T16:35:27Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+        // verify columns
+        columnValues.keys.forEach {
+            waitForNodes(it.uppercase(), count = 2)
+        } // despite there is only one table with column names, test sees two of them


Not sure if each check for table item deserves the same comment in the code. What do you think about extracting the logic somewhere else and use it like waitForTableNode(...)? Then we won't need to use count = 2 and additional comments in many places.

good idea, it will increase code readibility

lukaszgajewski-pega · 2026-01-15T16:42:12Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

        }
    }
+
+    private fun ComposeUiTest.allDescendantsOf(testTag: String) =


To be consistent with Compose APIs this function should be declared on SemanticsNodeInteractionsProvider and should start with on, e.g. onAllDescendantsOf(..).

lukaszgajewski-pega · 2026-01-15T16:43:30Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+            .onFirst().performScrollTo().performClick()
+    }
+
+    private fun SemanticsNodeInteractionCollection.findFirstWithText(text: String) =


IMO find(text) would be enough and more readable in tests. Collections API also has the same pattern:

lukaszgajewski-pega · 2026-01-15T16:44:04Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+
+    private fun ComposeUiTest.performTextInput(testTag: String, inputText: String) {
+        waitUntilAtLeastOneExists(hasTestTag(testTag))
+        onAllNodes(hasAnyAncestor(hasTestTag(testTag)))


Can't we reuse allDescendantsOf function here?

lukaszgajewski-pega · 2026-01-15T16:44:20Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+
+    private fun ComposeUiTest.performClick(testTag: String) {
+        waitUntilAtLeastOneExists(hasTestTag(testTag))
+        onAllNodes(hasAnyAncestor(hasTestTag(testTag)))


Can't we reuse allDescendantsOf function here?

lukaszgajewski-pega · 2026-01-15T16:45:09Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+        // adding new record via popup
+        onNodeWithText("+ Add cars").performScrollTo().performClick()
+        waitForNode("Add Record")
+        allDescendantsOf("ModalViewContainer").let { nodes ->


nodes seems to be too general - what about modal?

Btw, what do you think about using run or with instead of let? In that case we won't need to declare nodes everywhere, however it might be more problematic to find out on which this we are operating on.

modal seems to be most readable for me (despite its actual a collection)

lukaszgajewski-pega · 2026-01-15T16:59:52Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

        this.filter(hasText(text)).onFirst()

-    fun ComposeUiTest.waitUntilAtLeastOneExists(
+    private fun ComposeUiTest.waitUntilAtLeastOneExists(


In fact this should be named waitUntilExactlyOneExists, and this is already implemented in ComposeUiTest, except that the original implementation does not receive nodes collection.

However, I think we still might be able to use the original one:

waitUntilExactlyOneExists( hasAnyAncestorWithTag(carsReadonlyFieldGroup) and hasAnyAncestorWithTag("field_group_item_2") and hasText("Ford") )

or even below should be enough:

waitUntilExactlyOneExists( hasAnyAncestorWithTag("field_group_item_2") and hasText("Ford") )

sure it should be renamed to waitUntilExactlyOneExists

regarding rest of proposed changes:
I'm using this function in 3 places.
line 117 seems like good use of proposed solution
but in 225 and 320 I've already got the nodes so calling searching on hasAnyAncestorWithTag again would not be readable.

moreover when we want to change line 117 it cannot be

waitUntilExactlyOneExists( hasAnyAncestorWithTag("field_group_item_2") and hasText("Ford") )

because we have 2 repeating views with the same date and need to choose which one we are searching in
(there is "field_group_template_[Cars repeating view editable]" and "field_group_template_[Cars repeating view readonly]" and both has "Ford" inside)

lukaszgajewski-pega · 2026-01-15T17:00:28Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+        onAllNodes(hasContentDescription("Edit item 1")).onFirst().performScrollTo().performClick()
+        waitForNode("Edit Record")
+
+        allDescendantsOf("ModalViewContainer").let { nodes ->


nodes seems to be too general - what about modal?

lukaszgajewski-pega · 2026-01-15T17:01:13Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+        // verify table title
+        waitForNode("Cars editable table with popup")
+        // verify columns
+        columnValues.keys.forEach { waitForNodes(it.uppercase(), count = 2) } // despite there is only one table with column names, test sees two of them


See https://github.com/pegasystems/constellation-mobile-sdk/pull/99/changes#r2695135359

lukaszgajewski-pega · 2026-01-15T17:06:25Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

@@ -31,7 +36,7 @@ class EmbeddedDataTest : ComposeTest(PegaVersion.v24_2_2) {

    @Test
    fun test_embedded_data_repeating_view() = runComposeUiTest {


@marekpelc-pega Overall, good job with these tests, as I feel like they cover a lot, but more complex scenarios are difficult to read, and the Compose API doesn't help much.

In the meantime, I found a pretty interesting library for writing automated tests that works with Compose and seems quite powerful and appreciated by the community: https://github.com/KasperskyLab/Kaspresso

Maybe it'll be worth trying it someday :)

lukaszgajewski-pega · 2026-01-15T17:08:50Z

...t/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt

+        onAllNodes(hasAnyAncestor(hasTestTag(testTag)))
+
+    private fun SemanticsNodeInteractionCollection.filterDescendantsOf(testTag: String) =
+        filter(hasAnyAncestor(hasTestTag(testTag)))


I think that hasAnyAncestor(hasTestTag(testTag) deserves a reusable function: hasAnyAncestorWithTag(..) and then we could inline filterDescentatsOf and allDescendantsOf.

not sure if its necessary, its just 2 calls in 2 helpers, and even after extracting this calls to separate function it will not fit 1 line

lukaszgajewski-pega

Just finished reviewing your changes 😉 I added a few comments - nothing urgent, more like small things to think about.
Most of them are minor and mainly related to code readability rather than logic or the tests themselves. The tests run quite well overall. I executed them locally, and they passed without issues. There was a bit of work involved, but everything looks solid 🙂

tomaszmlocek-pega · 2026-01-20T13:29:40Z

scripts/dxcomponents/components/containers/view.component.js

        const label = configProps.label ?? "";
-        const showLabel = configProps.showLabel || this.DETAILS_TEMPLATES.includes(template) || this.props.showLabel;
-
+        const showLabel = (configProps.showLabel || this.DETAILS_TEMPLATES.includes(template)) ?? this.props.showLabel;


I think right side of this expression (after ?? operator) will never be used.

marekpelc-pega added 10 commits December 17, 2025 14:04

TASK-1828886-1: fixing issue with templates label (duplicated or inco…

3fe7522

…rrect)

TASK-1828886-1: fixing crash while entering new line or tab character…

e0bbecd

… in text area

TASK-1828886-1: fixing readonly mode for Time and DateTime components

8738b60

TASK-1828886-1: changing tables heading to be consistent with other h…

b819559

…eadings

TASK-1828886-1: EmbeddedData repeating view test enhancement

27ff16c

TASK-1828886-1: improve tests stability

03ba5c3

TASK-1828886-1: fixing IOS SwiftUI tests

0cd9536

TASK-1828886-1: fixing labels in FieldGroupTemplate on SwiftUI app

868b44e

TASK-1828886-3: adding tests for EmbeddedData tables

c80fc0f

TASK-1828886-3: previous PR review fixes

3af30b2

marekpelc-pega requested a review from a team as a code owner January 13, 2026 11:11

Merge branch 'master' into feature/pelcm/TASK-1828886-3-ed-tables-tests

ab15d77

marekpelc-pega force-pushed the feature/pelcm/TASK-1828886-3-ed-tables-tests branch from 5e93f8e to ed4ddc9 Compare January 14, 2026 19:12

TASK-1828886-3: fixing test

1d93c9c

marekpelc-pega force-pushed the feature/pelcm/TASK-1828886-3-ed-tables-tests branch from ed4ddc9 to 1d93c9c Compare January 14, 2026 19:29

TASK-1828886-3: minor tests refactor

09fe268

lukaszgajewski-pega reviewed Jan 15, 2026

View reviewed changes

lukaszgajewski-pega approved these changes Jan 15, 2026

View reviewed changes

TASK-1828886-3: review fixes in EmbeddedDataTest.kt

61f6e4c

marekpelc-pega force-pushed the feature/pelcm/TASK-1828886-3-ed-tables-tests branch from ece95fb to 61f6e4c Compare January 16, 2026 11:34

tomaszmlocek-pega reviewed Jan 20, 2026

View reviewed changes

TASK-1828886-1: review fixes in view.component.js

1730d15

tomaszmlocek-pega self-requested a review January 20, 2026 14:50

tomaszmlocek-pega approved these changes Jan 20, 2026

View reviewed changes

tomaszmlocek-pega merged commit 1e0f464 into master Jan 20, 2026
3 checks passed

lukaszgajewski-pega deleted the feature/pelcm/TASK-1828886-3-ed-tables-tests branch February 17, 2026 11:16

		@@ -31,7 +36,7 @@ class EmbeddedDataTest : ComposeTest(PegaVersion.v24_2_2) {

		@Test
		fun test_embedded_data_repeating_view() = runComposeUiTest {

Conversation

marekpelc-pega commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marekpelc-pega Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukaszgajewski-pega left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marekpelc-pega Jan 16, 2026 •

edited

Loading