Skip to content

TASK-1828886-3: EmbeddedData tables tests #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomaszmlocek-pega merged 15 commits into from
Jan 20, 2026
Merged

TASK-1828886-3: EmbeddedData tables tests #99

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3fe7522
TASK-1828886-1: fixing issue with templates label (duplicated or inco…
marekpelc-pega Dec 17, 2025
e0bbecd
TASK-1828886-1: fixing crash while entering new line or tab character…
marekpelc-pega Dec 17, 2025
8738b60
TASK-1828886-1: fixing readonly mode for Time and DateTime components
marekpelc-pega Dec 17, 2025
b819559
TASK-1828886-1: changing tables heading to be consistent with other h…
marekpelc-pega Dec 17, 2025
27ff16c
TASK-1828886-1: EmbeddedData repeating view test enhancement
marekpelc-pega Dec 17, 2025
03ba5c3
TASK-1828886-1: improve tests stability
marekpelc-pega Dec 19, 2025
0cd9536
TASK-1828886-1: fixing IOS SwiftUI tests
marekpelc-pega Dec 22, 2025
868b44e
TASK-1828886-1: fixing labels in FieldGroupTemplate on SwiftUI app
marekpelc-pega Dec 22, 2025
c80fc0f
TASK-1828886-3: adding tests for EmbeddedData tables
marekpelc-pega Jan 12, 2026
3af30b2
TASK-1828886-3: previous PR review fixes
marekpelc-pega Jan 13, 2026
ab15d77
Merge branch 'master' into feature/pelcm/TASK-1828886-3-ed-tables-tests
marekpelc-pega Jan 13, 2026
1d93c9c
TASK-1828886-3: fixing test
marekpelc-pega Jan 14, 2026
09fe268
TASK-1828886-3: minor tests refactor
marekpelc-pega Jan 15, 2026
61f6e4c
TASK-1828886-3: review fixes in EmbeddedDataTest.kt
marekpelc-pega Jan 16, 2026
1730d15
TASK-1828886-1: review fixes in view.component.js
marekpelc-pega Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
261 changes: 237 additions & 24 deletions ...otlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/cases/EmbeddedDataTest.kt
View file
Open in desktop

Large diffs are not rendered by default.

43 changes: 21 additions & 22 deletions scripts/dxcomponents/components/containers/templates/simple-table-manual.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ export class SimpleTableManualComponent extends BaseComponent {
presets,
allowActions,
allowTableEdit,
allowRowDelete,
allowRowEdit,
allowRowDelete: allowRowDeleteExpression,
allowRowEdit: allowRowEditExpression,
label: labelProp,
propertyLabel,
editMode,
Expand All @@ -108,10 +108,13 @@ export class SimpleTableManualComponent extends BaseComponent {
const conditions = this.#calculateConditions(editMode, allowActions, allowTableEdit)

this.referenceListStr = getContext(this.pConn).referenceListStr;
this.props.label = this.pConn.getInheritedProps().label ?? labelProp ?? propertyLabel;
this.props.label = this.pConn.getInheritedProps().label || labelProp || propertyLabel;
this.targetClassLabel = targetClassLabel;
this.props.addButtonLabel = targetClassLabel ? `+ Add ${targetClassLabel}` : "+ Add";
this.referenceList = referenceList;
this.referenceList = referenceList.map((element) => {
element.allowEdit = conditions.allowEditRow && evaluateAllowRowAction(allowRowEditExpression, element)
return element;
});
this.contextClass = this.#getContextClass(configProps);

this.pConn.setReferenceList(getReferenceList(this.pConn));
Expand Down Expand Up @@ -141,8 +144,18 @@ export class SimpleTableManualComponent extends BaseComponent {
this.props.columnLabels = this.#getColumnLabels(fieldDefs, resolvedFields);

if ((!this.#listsEqual(this.prevReferenceList, this.referenceList))) {
this.#buildRows(rawFields, editableMode, conditions.allowDeleteRow, allowRowDelete, conditions.allowEditRow, allowRowEdit);
this.#buildRows(rawFields);
}
this.props.rows = this.editableRows.map((row, rowIndex) => {
const allowDelete = conditions.allowDeleteRow && evaluateAllowRowAction(allowRowDeleteExpression, this.referenceList[rowIndex])
const showEditButton = editableMode && this.allowEditingInModal && this.referenceList[rowIndex].allowEdit
const showDeleteButton = editableMode && allowDelete
return {
cellComponentIds: row.cells.map((cell) => cell.component.compId),
showEditButton: showEditButton,
showDeleteButton: showDeleteButton
}
});
this.prevReferenceList = this.referenceList;
this.componentsManager.onComponentPropsUpdate(this)
}
Expand Down Expand Up @@ -200,13 +213,10 @@ export class SimpleTableManualComponent extends BaseComponent {
}
}

#buildRows(rawFields, editableMode, allowDelete, allowRowDeleteExpression, allowEdit, allowRowEditExpression) {
#buildRows(rawFields) {
const context = this.pConn.getContextName();
const newEditableRows = [];
this.referenceList.forEach((element, rowIndex) => {
const showDeleteButton = editableMode && allowDelete && evaluateAllowRowAction(allowRowDeleteExpression, element);
const showEditButton = editableMode && allowEdit && evaluateAllowRowAction(allowRowEditExpression, element) && this.allowEditingInModal;

const editableRow = this.editableRows[rowIndex];
const newEditableCells = [];
rawFields?.forEach((item, cellIndex) => {
Expand All @@ -216,7 +226,7 @@ export class SimpleTableManualComponent extends BaseComponent {
config: {
...item.config,
label: '',
displayMode: this.readOnlyMode || this.allowEditingInModal ? 'DISPLAY_ONLY' : undefined
displayMode: this.readOnlyMode || this.allowEditingInModal || !element.allowEdit ? 'DISPLAY_ONLY' : undefined
}
};
const referenceListData = getReferenceList(this.pConn);
Expand All @@ -238,20 +248,9 @@ export class SimpleTableManualComponent extends BaseComponent {
newEditableCells.push({ component: newComponent })
}
});
newEditableRows.push({
cells: newEditableCells,
showEditButton: showEditButton,
showDeleteButton: showDeleteButton
});
newEditableRows.push({ cells: newEditableCells});
});
this.editableRows = newEditableRows;
this.props.rows = newEditableRows.map((row) => {
return {
cellComponentIds: row.cells.map((cell) => cell.component.compId),
showEditButton: row.showEditButton,
showDeleteButton: row.showDeleteButton
}
});
}

#addSimpleTableRow() {
Expand Down
6 changes: 3 additions & 3 deletions scripts/dxcomponents/components/containers/view.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ export class ViewComponent extends ContainerBaseComponent {

const template = this.#resolveTemplateType(configProps);
const label = configProps.label ?? "";
const showLabel = configProps.showLabel || this.DETAILS_TEMPLATES.includes(template) || this.props.showLabel;

const showLabel = (configProps.showLabel || this.DETAILS_TEMPLATES.includes(template)) ?? this.props.showLabel;
Copy link
Copy Markdown
Contributor

@tomaszmlocek-pega tomaszmlocek-pega Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think right side of this expression (after ?? operator) will never be used.

const isTemplateWithHeader = !this.NO_HEADER_TEMPLATES.includes(template);
this.props.label = inheritedProps.label ?? label;
this.props.showLabel = (inheritedProps.showLabel ?? showLabel) && !this.NO_HEADER_TEMPLATES.includes(template);
this.props.showLabel = (inheritedProps.showLabel || showLabel) && isTemplateWithHeader;
this.props.visible = configProps.visibility ?? this.props.visible;

if (this.READ_ONLY_DETAILS_TEMPLATES.includes(template)) {
Expand Down
Loading