fix: header theme changes in embedded sample #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SambhuPega
requested review from
4manasa,
samhere06,
tumms2021389 and
vishalshrm539
tumms2021389
requested changes
Oct 29, 2025
Comment on lines
167
to
169
| if (caseTypes && caseTypes.length > 0) { | ||
| //mashupCaseType = caseTypes[0].pyWorkTypeImplementationClassName; | ||
| mashupCaseType = 'DIXL-MediaCo-Work-PurchasePhone'; | ||
| mashupCaseType = sdkConfigData.authConfig.mashupCaseType; | ||
| } |
Collaborator
There was a problem hiding this comment.
No need to modify this logic, it should be like below one
if (caseTypes && caseTypes.length > 0) {
mashupCaseType = caseTypes[0].pyWorkTypeImplementationClassName;
}
sdk-config.json
Outdated
| "sdk_optional_configs_doc_comment": "See the document(link below) for more details on all the available config settings", | ||
| "sdk_optional_configs_doc": "https://docs.pega.com/bundle/constellation-sdk/page/constellation-sdks/sdks/configuring-sdk-config-json.html", | ||
| "theme": "light", | ||
| "theme": "dark", |
Collaborator
There was a problem hiding this comment.
keep light as default theme
sdk-config.json
Outdated
Comment on lines
17
to
18
| "portalClientId": "25795373220702300272", | ||
| "mashupCaseType": "DIXL-MediaCo-Work-PurchasePhone" |
Collaborator
There was a problem hiding this comment.
No need of new key 'mashupCaseType', appMashupCaseType is already present below
| import StoreContext from '../../../bridge/Context/StoreContext'; | ||
| import createPConnectComponent from '../../../bridge/react_pconnect'; | ||
|
|
||
| import sdkConfigData from '../../../../../../sdk-config.json'; |
tsconfig.json
Outdated
| "allowJs": true, // must be false for @pega/pcore-pconnect-typedefs | ||
| "noImplicitAny": false, | ||
| "allowSyntheticDefaultImports": true, | ||
| "resolveJsonModule": true, |
tumms2021389
approved these changes
Oct 29, 2025
tumms2021389
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the header component style
case type added in the sdk config