Skip to content

fix: header theme changes in embedded sample #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 4 commits into from
Oct 29, 2025
Merged

fix: header theme changes in embedded sample #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80a910c
Theme file change and header component update in embedded
SambhuPega Oct 28, 2025
a20cd37
Added casetype in sdk-config for embedded and updated styles for Header
SambhuPega Oct 29, 2025
dcb3705
PR comments addressed
tumms2021389 Oct 29, 2025
8d9de0f
Merge branch 'master' into mod/tor/embeddedUpdate
tumms2021389 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-sdk-components/src/samples/Embedded/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { makeStyles } from '@mui/styles';

const useStyles = makeStyles(theme => ({
header: {
backgroundColor: theme.palette.mode === 'dark' ? 'var(--app-nav-bg)' : theme.palette.background.paper,
backgroundColor: theme.headerNav.backgroundColor,
borderBottom: `1px solid ${theme.palette.divider}`,
padding: '1rem 0'
},
Expand Down Expand Up @@ -64,10 +64,10 @@ const useStyles = makeStyles(theme => ({
margin: 0,
'& a': {
textDecoration: 'none',
color: theme.palette.mode === 'dark' ? 'var(--app-nav-color)' : theme.palette.text.primary,
color: theme.headerNav.navLinkColor,
transition: 'color 0.3s ease',
'&:hover': {
color: theme.palette.mode === 'dark' ? theme.palette.primary.contrastText : theme.palette.primary.main
color: theme.headerNav.navLinkHoverColor
}
},
'@media (max-width: 768px)': {
Expand Down Expand Up @@ -103,7 +103,7 @@ const useStyles = makeStyles(theme => ({
cursor: 'pointer',
zIndex: 1001,
padding: 0,
color: theme.palette.mode === 'dark' ? theme.palette.primary.contrastText : theme.palette.text.primary,
color: theme.headerNav.menuToggleColor,
'@media (max-width: 768px)': {
display: 'block'
}
Expand Down
3 changes: 1 addition & 2 deletions packages/react-sdk-components/src/samples/Embedded/MainScreen/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ export default function MainScreen(props) {
if (!mashupCaseType) {
const caseTypes = PCore.getEnvironmentInfo()?.environmentInfoObject?.pyCaseTypeList;
if (caseTypes && caseTypes.length > 0) {
//mashupCaseType = caseTypes[0].pyWorkTypeImplementationClassName;
mashupCaseType = 'DIXL-MediaCo-Work-PurchasePhone';
mashupCaseType = mashupCaseType = caseTypes[0].pyWorkTypeImplementationClassName;
}
}
let selectedPhoneGUID = '';
Expand Down
18 changes: 18 additions & 0 deletions packages/react-sdk-components/src/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ declare module '@mui/styles/defaultTheme' {
backgroundColor: string;
topColor: string;
};
headerNav: {
backgroundColor: string;
navLinkColor: string;
navLinkHoverColor: string;
menuToggleColor: string;
};
embedded: {
resolutionTextColor: string;
};
Expand Down Expand Up @@ -145,6 +151,12 @@ const lightTheme = createTheme({
}
}
},
headerNav: {
backgroundColor: '#ffffff',
navLinkColor: 'rgba(0, 0, 0, 0.87)',
navLinkHoverColor: '#3f51b5',
menuToggleColor: 'rgba(0, 0, 0, 0.87)'
},
actionButtons: {
primary: {
backgroundColor: '#cc0f60',
Expand Down Expand Up @@ -212,6 +224,12 @@ const darkTheme = createTheme({
}
}
},
headerNav: {
backgroundColor: 'var(--app-nav-bg)',
navLinkColor: 'var(--app-nav-color)',
navLinkHoverColor: '#ffffff',
menuToggleColor: '#ffffff'
},
actionButtons: {
primary: {
backgroundColor: '#C70BB5',
Expand Down
2 changes: 1 addition & 1 deletion sdk-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"appPortal": "",

"appMashupCaseType_comment": "If specified, uses this case type for mashup. Otherwise, uses the first case type found for the app",
"appMashupCaseType": "",
"appMashupCaseType": "DIXL-MediaCo-Work-PurchasePhone",

"excludePortals_comment": "Array of specific portals to avoid attempting to load with SDK",
"excludePortals": ["pxExpress", "Developer", "pxPredictionStudio", "pxAdminStudio", "pyCaseWorker", "pyCaseManager7"]
Expand Down