Skip to content

Conversation

@DaNussi
Copy link
Contributor

@DaNussi DaNussi commented Nov 18, 2025

Description

This PR resolves #98. I have gone ahead and replaced all occurrences of openjdk:8-jdk-slim with eclipse-temurin:8. This should be a drop-in replacement. I have only tested the Curseforge Generic egg; let me know if further testing is required. 😄

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

@parkervcp
Copy link
Contributor

We have pelican managed java install images now.

You can use either of the following. Each has a reason to be there. Some newer mc version will require java 17 to build properly.

ghcr.io/pelican-eggs/installers:java_8
ghcr.io/pelican-eggs/installers:java_17

…/pelican-eggs/installers:java_8;

side-effekt: all install images now include the jdk
@DaNussi DaNussi marked this pull request as draft November 18, 2025 12:00
@DaNussi
Copy link
Contributor Author

DaNussi commented Nov 18, 2025

Egg's that need Testing:

@parkervcp
Copy link
Contributor

Have you done a find for the openjdk images on all the eggs yet? I feel like this is missing many that will need to be updated. I am certain Fabric is on the list as I have tested that locally

@parkervcp
Copy link
Contributor

@DaNussi Can you please check for other eggs that use the old images as well please.

@DaNussi
Copy link
Contributor Author

DaNussi commented Nov 26, 2025

@parkervcp can do, but it's going to take some time i am currently bussy with university 😆

@parkervcp
Copy link
Contributor

@DaNussi we only have installer images for Java 8 and 17.

You would use either of these

ghcr.io/pelican-eggs/installers:java_8
ghcr.io/pelican-eggs/installers:java_17

@DaNussi
Copy link
Contributor Author

DaNussi commented Dec 2, 2025

@DaNussi we only have installer images for Java 8 and 17.

You would use either of these

ghcr.io/pelican-eggs/installers:java_8 ghcr.io/pelican-eggs/installers:java_17

For some eggs i need the java-21 installer. Should i create a PR in https://github.com/pelican-eggs/yolks that adds it or is there an alternative like using ghcr.io/parkervcp/yolks:debian and manualy installing java-21 ?


and isn't the image tag ghcr.io/parkervcp/installers:java_8 and not ghcr.io/pelican-eggs/installers:java_8?
If no where do i find the repo for the ghcr.io/pelican-eggs images?

…/installers:java_8"

changed "ghcr.io\/parkervcp\/yolks:java_11" to "ghcr.io\/pelican-eggs\/installers:java_17"
changed "ghcr.io\/parkervcp\/yolks:java_21" to "ghcr.io\/pelican-eggs\/installers:java_21" temporarily
@DaNussi
Copy link
Contributor Author

DaNussi commented Dec 2, 2025

I created a PR to add the installers. pelican-eggs/yolks#337

@DaNussi DaNussi changed the title changed all images from openjdk:8-jdk-slim to eclipse-temurin:8 changed all eggs to new installer images Dec 13, 2025
@parkervcp
Copy link
Contributor

A note. The pelican-eggs/yolks and parkervcp/yolks images are identical.

Do we think this is good to go @QuintenQVD0 ?

…image

# Conflicts:
#	java/paper/egg-pterodactyl-paper.json
- ftb-server
- fabric
- glowstone
- modrinth-generic
- quilt
fixed issue in the installation script where installer.jar gets killed
@DaNussi
Copy link
Contributor Author

DaNussi commented Dec 19, 2025

Tested Egg's:

  • Curse Forge Generic works with the changes from Fix for CurseForge Generic egg #92
  • Fabric
  • Forge Enhanced fixed installation issue
  • FTB Server
  • Glowstone
  • Modrinth Generic
  • Quilt
  • Sponge Forge can't test, version from main is already bugged
  • Vanilla Cord cannot test because https://dev.me1312.net/jenkins/job/VanillaCord/ is down

@DaNussi DaNussi marked this pull request as ready for review December 19, 2025 21:12
@QuintenQVD0
Copy link
Contributor

A note. The pelican-eggs/yolks and parkervcp/yolks images are identical.

Do we think this is good to go @QuintenQVD0 ?

This looks fine to me

@DaNussi
Copy link
Contributor Author

DaNussi commented Dec 21, 2025

Should I export all eggs from the panel? I have a script ready to go, but I don't want to overcomplicate the PR even further. I pushed the changes to an additional branch if needed i can just merge it into the current one DaNussi@e50db8c

@QuintenQVD0
Copy link
Contributor

Should I export all eggs from the panel? I have a script ready to go, but I don't want to overcomplicate the PR even further. I pushed the changes to an additional branch if needed i can just merge it into the current one DaNussi@e50db8c

Looking at that seems like it didn't go that well and the indentation is wrong, just keep it like this is fine

…installers to ghcr.io/pelican-eggs/installers
@DaNussi
Copy link
Contributor Author

DaNussi commented Dec 28, 2025

I changed all installation images to pelican-eggs.

I did not change the docker_images field because i don't know what to do in this case:
image

@DaNussi DaNussi requested a review from parkervcp December 28, 2025 17:38
@parkervcp
Copy link
Contributor

I changed all installation images to pelican-eggs.

I did not change the docker_images field because i don't know what to do

That's fine for now. You could replace them all with pelican-eggs but right now there is no real need right now.

Copy link
Contributor

@parkervcp parkervcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parkervcp parkervcp merged commit c44e840 into pelican-eggs:main Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Curseforge Generic

3 participants