Skip to content

Conversation

@DaNussi
Copy link

@DaNussi DaNussi commented Dec 2, 2025

Description

Added installers for java:

  • java-11
  • java-21
  • java-25

Required by pelican-eggs/minecraft#100

All Submissions:

  • Have you ensured there aren't other open Pull Requests for the same update or change?
  • Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

  1. Have you added your image to the Github workflows?
  2. Have you updated the README list to contain your new image?

@DaNussi
Copy link
Author

DaNussi commented Dec 2, 2025

@DaNussi DaNussi marked this pull request as draft December 2, 2025 13:08
@rmartinoscar
Copy link
Collaborator

I don't know why is this a draft other then the missing $ it looks good to me.

@DaNussi
Copy link
Author

DaNussi commented Dec 2, 2025

I don't know why is this a draft other then the missing $ it looks good to me.

I commited the wrong file here 4709f65

@DaNussi DaNussi marked this pull request as ready for review December 2, 2025 13:17
@DaNussi
Copy link
Author

DaNussi commented Dec 2, 2025

Now it should be fine. For some reason intellij added dotnet/10/Dockerfile even without changes 😄

@rmartinoscar
Copy link
Collaborator

Now it should be fine. For some reason intellij added dotnet/10/Dockerfile even without changes 😄

#CRLF gotta love windows

Co-authored-by: MartinOscar <[email protected]>
@DaNussi
Copy link
Author

DaNussi commented Dec 2, 2025

Should i revert the changes to dotnet/10/Dockerfile?

@parkervcp
Copy link
Collaborator

Also java 22 and 23 are out of support.

@rmartinoscar rmartinoscar changed the title added installers for java-11 java-21 java-22 java-23 java-25 Add installers for Java 11, 21 & 25 Dec 2, 2025
@parkervcp parkervcp merged commit c7f5afd into pelican-eggs:master Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants