Fixing Scheduler on Windows w/ Spaces in PHP_BINARY Path#130
Open
AndyM84 wants to merge 3 commits intopeppeocchi:masterfrom
Open
Fixing Scheduler on Windows w/ Spaces in PHP_BINARY Path#130AndyM84 wants to merge 3 commits intopeppeocchi:masterfrom
AndyM84 wants to merge 3 commits intopeppeocchi:masterfrom
Conversation
mabar
reviewed
Mar 21, 2023
Co-authored-by: Marek Bartoš <bartos.developer152@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some code to catch if running on Windows and the PHP_BINARY path includes spaces. Adds double quotes around the value of
$binso it can run without issues.Tested as working on Windows 10 with PHP 7.4 and 8.0.
I believe this should also address #129.