Skip to content

Fixing Scheduler on Windows w/ Spaces in PHP_BINARY Path #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyM84 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing Scheduler on Windows w/ Spaces in PHP_BINARY Path #130

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24dd55b
Adding guard for Windows bin paths with spaces
AndyM84 Jan 6, 2022
1109821
Fixing indentation to spaces
AndyM84 Jan 6, 2022
a67c0e0
Update src/GO/Scheduler.php
AndyM84 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/GO/Scheduler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ public function php($script, $bin = null, $args = [], $id = null)
$bin = $bin !== null && is_string($bin) && file_exists($bin) ?
$bin : (PHP_BINARY === '' ? '/usr/bin/php' : PHP_BINARY);

if (PHP_OS_FAMILY == 'Windows' && stripos($bin, ' ') !== false) {
$bin = '"{$bin}"';
}

$job = new Job($bin . ' ' . $script, $args, $id);

if (! file_exists($script)) {
Expand Down