Skip to content

mongodb_mongod_wiredtiger_cache_max_bytes -> mongodb_ss_wt_cache_maximum_bytes_configured (oldName and newName) #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BupycHuk merged 6 commits into from
Feb 5, 2025
Merged

mongodb_mongod_wiredtiger_cache_max_bytes -> mongodb_ss_wt_cache_maximum_bytes_configured (oldName and newName) #1023

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77fcdf3
Update v1_compatibility.go
msotnikov Feb 5, 2025
bf52d3c
Update diagnostic_data_collector_test.go
msotnikov Feb 5, 2025
10e55cc
Update v1_compatibility.go
msotnikov Feb 5, 2025
d2f7988
Update diagnostic_data_collector_test.go
msotnikov Feb 5, 2025
a867256
Update v1_compatibility.go
msotnikov Feb 5, 2025
6f2e864
Merge branch 'main' into patch-1
BupycHuk Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/diagnostic_data_collector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,14 @@ func TestAllDiagnosticDataCollectorMetrics(t *testing.T) {
"mongodb_mongod_wiredtiger_cache_bytes",
"mongodb_mongod_wiredtiger_transactions_total",
"mongodb_mongod_wiredtiger_cache_bytes_total",
"mongodb_mongod_wiredtiger_cache_max_bytes",
"mongodb_op_counters_total",
"mongodb_ss_mem_resident",
"mongodb_ss_mem_virtual",
"mongodb_ss_metrics_cursor_open",
"mongodb_ss_metrics_getLastError_wtime_totalMillis",
"mongodb_ss_opcounters",
"mongodb_ss_opcountersRepl",
"mongodb_ss_wt_cache_maximum_bytes_configured",
"mongodb_ss_wt_cache_modified_pages_evicted",
}
actualMetrics = filterMetrics(actualMetrics, filters)
Expand Down
4 changes: 2 additions & 2 deletions exporter/v1_compatibility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,8 @@ var conversions = []conversion{
newName: "mongodb_ss_metrics_getLastError_wtime_totalMillis",
},
{
oldName: "mongodb_ss_wt_cache_maximum_bytes_configured",
newName: "mongodb_mongod_wiredtiger_cache_max_bytes",
oldName: "mongodb_mongod_wiredtiger_cache_max_bytes",
newName: "mongodb_ss_wt_cache_maximum_bytes_configured",
Copy link
Member

@BupycHuk BupycHuk Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we can remove these lines as we have the same at line 439.

Copy link
Contributor Author

@msotnikov msotnikov Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the reason of test fail was this duplicate. So I just removed extra rows and reverted any other changes

},
{
oldName: "mongodb_mongod_db_collections_total",
Expand Down
Loading