Skip to content

Conversation

@nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Nov 19, 2024

K8SPG-511 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
we have default value for spec.backups.pgbackrest.restore.enabled . So restore part would be added in our yaml in openshift even if we don't have it in alm-example. But in restore part we have required field: spec.backups.pgbackrest.restore.repoName . And now we should add it too.

Cause:
Short explanation of the root cause of the issue if applicable.
Openshift transforms alm-example in yaml where fields with default values added
Solution:
add default values for required fields.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@nmarukovich nmarukovich marked this pull request as ready for review November 19, 2024 15:33
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have task number in the desc? When you add a comment on a field kubebuilder treats as a field description. Did you intended to have it on CRD desc?

… should be added to this field to avoid the problem under openshift installation
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
major-upgrade passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 6d9ebba
image: perconalab/percona-postgresql-operator:PR-952-6d9ebbab5

@egegunes egegunes added this to the v2.6.0 milestone Nov 25, 2024
@nmarukovich nmarukovich merged commit f5ad02c into main Nov 25, 2024
13 checks passed
@nmarukovich nmarukovich deleted the K8SPG-511_add_default_values branch November 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants