-
Notifications
You must be signed in to change notification settings - Fork 67
K8SPG-511 add default values #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into K8SPG-511_add_default_values
inelpandzic
requested changes
Nov 20, 2024
| default: repo1 | ||
| description: |- | ||
| The name of the repository | ||
| K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have task number in the desc? When you add a comment on a field kubebuilder treats as a field description. Did you intended to have it on CRD desc?
… should be added to this field to avoid the problem under openshift installation
egegunes
approved these changes
Nov 20, 2024
Collaborator
commit: 6d9ebba |
inelpandzic
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
we have default value for spec.backups.pgbackrest.restore.enabled . So restore part would be added in our yaml in openshift even if we don't have it in alm-example. But in restore part we have required field: spec.backups.pgbackrest.restore.repoName . And now we should add it too.
Cause:
Short explanation of the root cause of the issue if applicable.
Openshift transforms alm-example in yaml where fields with default values added
Solution:
add default values for required fields.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability