Skip to content

K8SPG-511 add default values #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmarukovich merged 11 commits into from
Nov 25, 2024
Merged

K8SPG-511 add default values #952

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c8defe
K8SPG-511 add default values
nmarukovich Nov 19, 2024
18886ed
Merge branch 'main' of github.com:percona/percona-postgresql-operator…
nmarukovich Nov 19, 2024
05b2add
fix trivy check
nmarukovich Nov 19, 2024
6d0b521
fix PR
nmarukovich Nov 19, 2024
1b583b9
fix PR
nmarukovich Nov 19, 2024
90647da
update to string
nmarukovich Nov 19, 2024
bed5b21
fix tests
nmarukovich Nov 19, 2024
2d25a81
fix quotes
nmarukovich Nov 19, 2024
34792db
fix PR comments
nmarukovich Nov 20, 2024
c407cd3
K8SPG-511: Add default values. The default value for enabled variable…
nmarukovich Nov 20, 2024
6d9ebba
image fix
nmarukovich Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
ignore-unfixed: true
vuln-type: 'os,library'
severity: 'CRITICAL,HIGH'
version: 'v0.57.1'

- name: Build an image from Dockerfile (linux/amd64)
run: |
Expand All @@ -57,3 +58,4 @@ jobs:
ignore-unfixed: true
vuln-type: 'os,library'
severity: 'CRITICAL,HIGH'
version: 'v0.57.1'
20 changes: 16 additions & 4 deletions build/crd/crunchy/generated/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3274,7 +3274,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -4515,10 +4518,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -6598,7 +6603,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -7938,10 +7946,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -13946,8 +13956,10 @@ spec:
in a PostgresCluster.
properties:
enabled:
description: Whether or not the operator should allow switchovers
in a PostgresCluster
default: false
description: |-
Whether or not the operator should allow switchovers in a PostgresCluster
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
type: boolean
targetInstance:
description: |-
Expand Down
5 changes: 4 additions & 1 deletion build/crd/percona/generated/pgv2.percona.com_perconapgbackups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
Copy link
Contributor

@inelpandzic inelpandzic Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have task number in the desc? When you add a comment on a field kubebuilder treats as a field description. Did you intended to have it on CRD desc?

pattern: ^repo[1-4]
type: string
s3:
Expand Down
20 changes: 16 additions & 4 deletions build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3425,7 +3425,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -4666,10 +4669,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -6248,7 +6253,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -7588,10 +7596,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -13282,8 +13292,10 @@ spec:
in a PostgresCluster.
properties:
enabled:
description: Whether or not the operator should allow switchovers
in a PostgresCluster
default: false
description: |-
Whether or not the operator should allow switchovers in a PostgresCluster
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
type: boolean
targetInstance:
description: |-
Expand Down
25 changes: 20 additions & 5 deletions config/crd/bases/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -3830,7 +3833,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -5071,10 +5077,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -6653,7 +6661,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -7993,10 +8004,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -13687,8 +13700,10 @@ spec:
in a PostgresCluster.
properties:
enabled:
description: Whether or not the operator should allow switchovers
in a PostgresCluster
default: false
description: |-
Whether or not the operator should allow switchovers in a PostgresCluster
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
type: boolean
targetInstance:
description: |-
Expand Down
20 changes: 16 additions & 4 deletions config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3256,7 +3256,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -4505,10 +4508,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -6558,7 +6563,10 @@ spec:
- bucket
type: object
name:
description: The name of the repository
default: repo1
description: |-
The name of the repository
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
s3:
Expand Down Expand Up @@ -7898,10 +7906,12 @@ spec:
More info: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/
type: string
repoName:
default: repo1
description: |-
The name of the pgBackRest repo within the source PostgresCluster that contains the backups
that should be utilized to perform a pgBackRest restore when initializing the data source
for the new PostgresCluster.
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
pattern: ^repo[1-4]
type: string
resources:
Expand Down Expand Up @@ -13888,8 +13898,10 @@ spec:
in a PostgresCluster.
properties:
enabled:
description: Whether or not the operator should allow switchovers
in a PostgresCluster
default: false
description: |-
Whether or not the operator should allow switchovers in a PostgresCluster
K8SPG-511. The default value should be added to this field to avoid the problem under openshift installation
type: boolean
targetInstance:
description: |-
Expand Down
Loading