-
Notifications
You must be signed in to change notification settings - Fork 168
K8SPSMDB-1472 introduce grouping of storageScaling options #2213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8287505 to
7f6073f
Compare
7f6073f to
eb47b70
Compare
hors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkech please update helm chart PR
| if spec.GrowthStep.IsZero() { | ||
| spec.GrowthStep = resource.MustParse("2Gi") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to duplicate this?
| type StorageScalingSpec struct { | ||
| // EnableExternalAutoscaling delegates volume autoscaling to an external system (e.g., Kubernetes VPA) | ||
| // When enabled, the operator skips internal autoscaling and resize operations | ||
| EnableExternalAutoscaling bool `json:"enableExternalAutoscaling,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also validate for EnableExternalAutoscaling ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate what we should validate here? Related to autoscaling or the EnableVolumeScaling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit: 482da7a |
Due to the high volume of requests, we're unable to provide free service for this account. To continue using the service, please upgarde to a paid plan.
CHANGE DESCRIPTION
Problem:
Given that a lot storage scaling related options started to appear on the top level of the spec file, we can combine them together under the following:
We are also introducing a validation rule on CRD level that autoscaling cannot be enabled when enableVolumeScaling is disabled.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability