-
-
Notifications
You must be signed in to change notification settings - Fork 21
Code Quality Fixes #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apermo
wants to merge
28
commits into
pfefferle:master
Choose a base branch
from
apermo:fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
eec0192
refactor: remove return values, as `autonomie_save_post` is hooked in…
apermo ba9cf2f
refactor: simplify unset calls for query variables in compat.php
apermo 3aeee73
refactor: fix phpdoc return types for post format functions in feed.p…
apermo 976f1cb
refactor: reorder condition for post format feed discovery in feed.php
apermo 5daf2a4
refactor: update comments for clarity in customizer.php and featured-…
apermo 6bf8f11
refactor: update phpdoc for parameters and return types in compat.php
apermo 8b49e3c
refactor: improve code clarity and consistency in semantics.php
apermo fbe89be
refactor: improve comment clarity in featured-image.php
apermo c8b735e
chore: update PHP version requirement to 7.4 and configure plugin all…
apermo 979168a
refactor: enhance code clarity and consistency in template-functions.php
apermo 2306e22
refactor: improve phpdoc clarity for parameters and return type in we…
apermo 459456e
refactor: streamline require statements and improve function formatti…
apermo bfb4ce5
refactor: improve phpdoc clarity and consistency in activitypub.php
apermo d079ed4
refactor: improve phpdoc clarity and consistency in post-kinds.php
apermo 70cf320
refactor: improve code formatting and consistency in syndication-link…
apermo 9fd738f
refactor: fix attribute name from 'width' to 'with' in indie-action e…
apermo 7c23915
refactor: improve code formatting and readability in entry-header.php
apermo c7b2805
refactor: improve code formatting and consistency in entry-nav.php
apermo 0c457dd
refactor: Removed unsupported attribute `type="text"` from `textarea`…
apermo 4b52d98
refactor: Removed unsupported attribute `type="text"` from `textarea`…
apermo d5cc65d
refactor: fix indentation in page-banner.php
apermo 7af6a78
chore: phpcbf changes in /templates/
apermo b5d0bbd
refactor: phpcbf, improve code formatting and consistency in multiple…
apermo cbce161
refactor: improve translator comments for clarity in comments.php
apermo 0eb808a
chore: update tested version and PHP requirements in readme.md
apermo 534a4e0
refactor: phpcbf - improve code readability and formatting in multipl…
apermo 0fc955d
fix: update profile links to use HTTPS for improved security
apermo 167b835
refactor: phpcbf and added missing `echo` to functions.php
apermo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -470,7 +470,7 @@ function autonomie_comment( $comment, $args, $depth ) { | |||||
| $GLOBALS['comment'] = $comment; | ||||||
| ?> | ||||||
| <li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>"> | ||||||
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> | ||||||
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php echo $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> | ||||||
|
||||||
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php echo $comment->comment_type; ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> | |
| <article id="comment-<?php comment_ID(); ?>" class="comment <?php echo esc_attr( $comment->comment_type ); ?>" itemprop="comment" itemscope itemtype="https://schema.org/Comment"> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfefferle Review here, this
echowas missing before, please verify that this has no sideeffects, alternatively we can remove the output.