feat(ValidHookName): Add sniff for hook name in PHP attributes

[RuZniki]

Issue: https://www.drupal.org/project/coder/issues/3499291

[klausi]

@RuZniki nice to hear from you :)

Left some comments, please also check the test fails.

[klausi]

for all those conditions we should check first with isset() if the next token is there. This will help prevent failures in live coding when the code is just being written.

[RuZniki]

I swtiched to ->findNext, do you think this is enough?

[RuZniki]

@klausi I am also happy to get feedback from you, thanks a lot for your review.

I moved sniff to \Drupal\Sniffs\Attributes\ValidHookNameSniff.
And moved tests from bad.php to \Drupal\Test\Attributes\ValidHookNameUnitTest.
I decide not to test, when name arguments for Hook attribute in wrong order. Example:

#[Hook(method: "userLogin", hook: "hook_user_login")] 

I believe this should not be a part of this sniff.

I add special handling for hook_hook_info(). But still not sure about this case.

PR is ready for review.

[RuZniki]

I removed special handling for "hook_hook_info()".

[klausi]

Sorry for the delay!

Looks good to me, just 2 minor things inline.

[klausi]

the strlen() condition here can be removed, this was already checked before.

We should not add additional conditions with $fix, it would be very confusing if the fixer does not always work.

[RuZniki]

I tried to avoid case when hook is not finished, and it's just "hook_".
Now I get your point, I will move second clause to above statement. Thanks.

[klausi]

we should use this in the error message above like "The hook name should not start with 'hook_', expected '%s' but found '%s".

[RuZniki]

Thanks, I update error message.
Result example

The hook name should not start with 'hook_', expected 'node_alter' but found 'hook_node_alter' (Drupal.Attributes.ValidHookName.HookPrefix)

[klausi]

Thanks, Drupal core regression tests are failing, but looks unrelated to this issue. Will check in a follow-up!