SPOC-345: Move zodan sync test to separate github action #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danolivo
force-pushed
the
spoc-345
branch
22 times, most recently
from
657e32a to
35a6b4c
Compare
Designed to be highly competitive, this test consumes more CPU, disk, and memory resources than usual. To let people pass basic checks on their ongoing commits faster, turn off this test in the schedule and separate it as a GitHub action. Also, it appears that we copied Spock into the base image. Hence, the 'step-1' Docker image might use oldish versions of the patches.
danolivo
changed the title
There are some corner cases that, at least for now, need to involve both the publisher and the subscriber when we try to determine whether all the data is replicated (synchronisation has finished). So, rewrite the sync code to sync_event/wait calls. It seems that if we improve wait functions a little, it may serve to multiple purposes. For example, we may add sync_event to the wait function, replace integer timeouts with the Interval type, and introduce 'verbose' mode. And yes, rewrite it as a function.
Contributor
Author
|
@pct960, doing this, I found an issue with the base image creation Dockerfile. If you can, please take a look - just to understand how worse it is and if my fix is correct. |
pct960
suggested changes
Dec 2, 2025
Contributor
pct960
left a comment
pct960
left a comment
There was a problem hiding this comment.
Mostly looks good. Only some minor changes are needed.
I couldn't get around to running the workflow, however.
Will do it after you merge.
mason-sharp
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are me also fix the issue with base image ...